From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5A29C433EF for ; Thu, 23 Jun 2022 17:31:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 454D98E016D; Thu, 23 Jun 2022 13:31:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DDD98E0144; Thu, 23 Jun 2022 13:31:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 257D08E016D; Thu, 23 Jun 2022 13:31:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1047F8E0144 for ; Thu, 23 Jun 2022 13:31:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D051D20B38 for ; Thu, 23 Jun 2022 17:31:36 +0000 (UTC) X-FDA: 79610192592.09.92D0C2D Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf02.hostedemail.com (Postfix) with ESMTP id 1290480021 for ; Thu, 23 Jun 2022 17:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656005494; x=1687541494; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=zIaYVEomzwgXfaMMISVY2yLjmfGKJg5F3MdqvIB4X34=; b=j8Lhkei6eQoH5QoSXCRxUbrbnllsKUsXJK88sb35zw1p1UrTunejJHBl 97yg0NW4nen3pLLjRbM1BSmk/n6UXDUMmAG23mOhSU0QWVGhjGUg2xlZN q+Ip/cKdUNQEtfc18anoo352+MF27+nYZxibN7Oe4QXfsUK4k/ivoGMz9 yA8vpF5YSJaO/3qgqyehUVc5AAytHxb6hFltNagtVZxwZlNSHc58SGq42 YLeJ3FnY/qQmZlJrViL8cRNARzcc2fA9G/hFee+bPuTfsEWyzeQAl4GzZ 4ysJmR4VxFp84dxGHnHQsxALuH0+P2JggQnDQmPd27IHi5wIARK+4lxSs Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="342472488" X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="342472488" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:31:32 -0700 X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="563533778" Received: from ckeane-mobl1.amr.corp.intel.com (HELO [10.209.81.98]) ([10.209.81.98]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:31:31 -0700 Message-ID: <9b350e82-9fcf-b871-ed6c-92848dfa484e@intel.com> Date: Thu, 23 Jun 2022 10:31:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCHv7 13/14] x86/tdx: Refactor try_accept_one() Content-Language: en-US To: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel Cc: Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Mike Rapoport , David Hildenbrand , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220614120231.48165-1-kirill.shutemov@linux.intel.com> <20220614120231.48165-14-kirill.shutemov@linux.intel.com> From: Dave Hansen In-Reply-To: <20220614120231.48165-14-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656005494; a=rsa-sha256; cv=none; b=AKrzYjr0YlTGtkv/nkB5cDz/FQ7hZIGaPHHa5T5hYg3RDsfxpsclxmmE9ezreFaV77bNWq z4RshGgqIEy2NNoW4DELVUWO0hjeZGkVIf0eLYaETr3XcL+8AzkCGLAjdQk7ysW3/7T6+5 GJEyhbYDzgntwlBMqYjB4rWFwHtwAug= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=j8Lhkei6; spf=none (imf02.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656005494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mPhVG13ODu/32XZYGH4C8al74ZOk3vVqbmjWt3NpoUE=; b=Gph9IXFF12FRLAfNIiQgCLhfNoPmf61HyTrVu16e9OT592cTQKw5DddUQvhgEkhba6mOeu xm/hjm5suA45LtO+ROou0grPtnoIAtkTL7vfCXOud/SkJPR3oSMxoZwk8fc+UnMXsnjD5C PceX3P85PnibaqI6KwwycSLVFuJjQMs= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1290480021 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=j8Lhkei6; spf=none (imf02.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Stat-Signature: 6wh55gfgua3r3h7wzfuedx9yunu4f61i X-HE-Tag: 1656005493-654161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/14/22 05:02, Kirill A. Shutemov wrote: > Rework try_accept_one() to return accepted size instead of modifying > 'start' inside the helper. It makes 'start' in-only argumaent and ^ argument > streamlines code on the caller side. > > Signed-off-by: Kirill A. Shutemov > Suggested-by: Borislav Petkov I'm not sure how much it actually streamlines things. The line count looks pretty similar. But, I do generally dislike implicit return values, so with that typo fixed: Reviewed-by: Dave Hansen