From: Jens Axboe <axboe@kernel.dk>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
torvalds@linux-foundation.org
Cc: jack@suse.cz, tj@kernel.org,
syzbot+c0cf869505e03bdf1a24@syzkaller.appspotmail.com,
christophe.jaillet@wanadoo.fr, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, syzkaller-bugs@googlegroups.com,
zhangweiping@didichuxing.com, akpm@linux-foundation.org,
dvyukov@google.com, linux-block@vger.kernel.org
Subject: Re: INFO: task hung in wb_shutdown (2)
Date: Thu, 3 May 2018 09:25:13 -0600 [thread overview]
Message-ID: <9cafa39a-aa2e-f4f0-02ae-a11e7ddace8d@kernel.dk> (raw)
In-Reply-To: <201805020714.FDD52145.OOJtOFVFSMLQFH@I-love.SAKURA.ne.jp>
On 5/1/18 4:14 PM, Tetsuo Handa wrote:
>>From 1b90d7f71d60e743c69cdff3ba41edd1f9f86f93 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Wed, 2 May 2018 07:07:55 +0900
> Subject: [PATCH v2] bdi: wake up concurrent wb_shutdown() callers.
>
> syzbot is reporting hung tasks at wait_on_bit(WB_shutting_down) in
> wb_shutdown() [1]. This seems to be because commit 5318ce7d46866e1d ("bdi:
> Shutdown writeback on all cgwbs in cgwb_bdi_destroy()") forgot to call
> wake_up_bit(WB_shutting_down) after clear_bit(WB_shutting_down).
>
> Introduce a helper function clear_and_wake_up_bit() and use it, in order
> to avoid similar errors in future.
Queued up, thanks Tetsuo!
--
Jens Axboe
next prev parent reply other threads:[~2018-05-03 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 17:10 INFO: task hung in wb_shutdown (2) syzbot
2018-04-24 12:19 ` Tetsuo Handa
2018-05-01 10:27 ` Tetsuo Handa
2018-05-01 16:06 ` Linus Torvalds
2018-05-01 21:30 ` Jens Axboe
2018-05-01 22:14 ` Tetsuo Handa
2018-05-03 15:13 ` Jan Kara
2018-05-03 15:25 ` Jens Axboe [this message]
2018-05-01 16:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cafa39a-aa2e-f4f0-02ae-a11e7ddace8d@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dvyukov@google.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=syzbot+c0cf869505e03bdf1a24@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).