From: Florian Fainelli <f.fainelli@gmail.com>
To: Li zeming <zeming@nfschina.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mempool: Optimize the mempool_create_node function
Date: Wed, 15 Mar 2023 10:53:06 -0700 [thread overview]
Message-ID: <9d478a5d-a7af-ab9f-a04e-fc40a95bc861@gmail.com> (raw)
In-Reply-To: <20230315191243.3289-1-zeming@nfschina.com>
On 3/15/23 12:12, Li zeming wrote:
> The pool pointer variable gets the kzalloc_node function return value
> directly at definition time, which should be more concise.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
This looks pretty useless as a change, the generated code is going to be
the same before/after, it is also not more readable, and it is
definitively not an optimization in the sense that optimization should
be used as meaning: the code is more efficient after that change.
--
Florian
parent reply other threads:[~2023-03-15 17:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230315191243.3289-1-zeming@nfschina.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d478a5d-a7af-ab9f-a04e-fc40a95bc861@gmail.com \
--to=f.fainelli@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).