From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B92C6FD1D for ; Wed, 15 Mar 2023 17:53:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8B876B0071; Wed, 15 Mar 2023 13:53:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C146D6B0072; Wed, 15 Mar 2023 13:53:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8F6E6B0075; Wed, 15 Mar 2023 13:53:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 946106B0071 for ; Wed, 15 Mar 2023 13:53:15 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6DEB9120896 for ; Wed, 15 Mar 2023 17:53:15 +0000 (UTC) X-FDA: 80571879150.12.D4A400D Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf01.hostedemail.com (Postfix) with ESMTP id 86FB840028 for ; Wed, 15 Mar 2023 17:53:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=djw7yUfv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of f.fainelli@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678902793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Phl8VF4w8DmD63ACWK76eFJT4/Q2JfCIItsfspissxQ=; b=vObFs3ytE6AsPxGnU6Qias0u6PMr8XxBwaAlOgaThFIHgqBIG6sTkfpF3VLRJb7Vo+V263 OVjYyevIUwUh4XcziaMuFiEROm7OpXrGn7uPOoo8NBi2xG4a2XIy8NuEF+g5NM7WFtwVxd AzjKP/19rHjjalB0cL6nvr4Fb1bBwKw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=djw7yUfv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of f.fainelli@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678902793; a=rsa-sha256; cv=none; b=yx50POyMJ/9XCnv6Ghttl22h1nnmizlCkROnDkA+YdCXUADVXQg96pJpwZqj1yuCNZxtAn Jq/bATYCMKL0efS/zmUcV8R+wqK4ZUdE6DMMswgRPldDWJ8zMT8kvdvFZBUDRtVsSY/bUK GL6UmCXnpd5RjMOZa2F9bCcz5rp8cZA= Received: by mail-pf1-f180.google.com with SMTP id n16so6094555pfa.12 for ; Wed, 15 Mar 2023 10:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678902792; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Phl8VF4w8DmD63ACWK76eFJT4/Q2JfCIItsfspissxQ=; b=djw7yUfvvWLdQrSrLVpKDbcWeFR6bzBsMNXff7qPIlRXgwiZIesBc8lFUzUS5VNi36 FHJsKXQYzOB0ftKKh+4RAxSrGE1Hit5YsALleFADD0KS6I5WRC/RDgDV/rbj6Vw9eunO 56Q79+7ZAK3b26QR3+r1cBDslSvY01dihVAb5fMAXrAz44ijMIDBeEirCKL4437DY7+I ecvG1+1nxssTHI5FnXRfM7lffRIr9omA1GzsuO/5CkOsmt7fEvELraZ8PYoNLocd5nDI MJxh06CyTCw+CfNTUWlX0dqUQ/K6khZU3YCmwDt49rMHu5gQ9hqKr2u3FPvJ8bKObqUN iN/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678902792; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Phl8VF4w8DmD63ACWK76eFJT4/Q2JfCIItsfspissxQ=; b=pTKDsgqtc0LeKRjdA/4YiFIL+qr1vDLKWJijAvWB8XXL0pNID+IqkogZHVmJpjX0gU U7xztRHQB0lxo5ckFWpL0y6F0RuBxdyohrU4NhZmF7DXp+ejaOxhLNj7zM3AU3yIqf4e ktfcTQsmCysrDTwtMBmNGSuiqhs4Kvod0vLjXpSUaBWH0IwX6tdNnBVYy6Rc3s/8X83z yDWDoQMgfV7qNfPT4v8SKbQVNlGU+0kTAd28+Jifdy6H4UcShEHqLcoM2MCyyPzVl5zM BZVae5Vu75AhGGeVyHCBvNJN9aEt+jPJMBKPi/ZqamXtnWd2ApzqSjUyULMohBA6orYY YnpA== X-Gm-Message-State: AO0yUKVyiKBFZsi2u3ps2gGbQzVmKAkZOcNM2/rRggLHi0K6anVs35pm AtsVlc6s7bryrVlunHKHekM= X-Google-Smtp-Source: AK7set+SM+zn4erh1bUIBARawNAVAK8nzQuJtFlFcoaBeUfUK2suB+pA8P+adB1EBT2xhRKGn4AdlQ== X-Received: by 2002:aa7:9d03:0:b0:622:85e2:fb93 with SMTP id k3-20020aa79d03000000b0062285e2fb93mr544227pfp.15.1678902792181; Wed, 15 Mar 2023 10:53:12 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id i17-20020aa787d1000000b005897f5436c0sm3836457pfo.118.2023.03.15.10.53.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 10:53:11 -0700 (PDT) Message-ID: <9d478a5d-a7af-ab9f-a04e-fc40a95bc861@gmail.com> Date: Wed, 15 Mar 2023 10:53:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] mm: mempool: Optimize the mempool_create_node function Content-Language: en-US To: Li zeming , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230315191243.3289-1-zeming@nfschina.com> From: Florian Fainelli In-Reply-To: <20230315191243.3289-1-zeming@nfschina.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 86FB840028 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 11u4dqt57d8fcw1f4wsh5ahpid7r9wbn X-HE-Tag: 1678902793-272748 X-HE-Meta: U2FsdGVkX19B2qOw+or1dV1kVmNdfGeLQ8ZZdMgmIiJWnWWhrubj6SltZZghm/Z4cO6Sde7s5Yrt82ObEV19uhVOjB1HO7xgTguhzxnHVkhExZd+NL1kHbnvU8cbrnEbF+klCaaW8k1uIC2EbOGTOYVO4mR4z7zy8btDLAcpLOV/VlzDD1nfdtcxZhuzsotxbFWB0PBxm7HpUIYShIX+7uCAXtGH/uRaUPDe3+oYZVHQpsyzCs6kg0MF/MVTCyncd6Cr5ht5I6LpEX80WnB3MWs2dwMyajTxhQpf5H9C3rYQhNn4qge+srHeu75EAUCLtz9WDmSBiSE/lWtQSqeke9b1YI+ipzS+CycvgB3x+d7GHJXs1s7vCc9KU9Q1fut6BHQ22IelbR1UJQ93CHuVVvrTBSRF9WLG5AS8BpcKT6dNdO8IWT8TDP72N9DQvsVarGeM05JT8cU6mw1sEkC3d3UJ8Eul6Pjhx+QDwg8ifZQ37Jli1HVduK4MsCFrDLeetZkqnoytkSsjCyeDJnTIdIsivO6C6JISyUNOVywtSMW/U4iSxR8xXrKP7O6De/ejnev5kglYHftNmqtqNM4Fox/h1oIM2IMaug+w0LECXz9fZZoW/+esoBCesBxDv+IfMhsx0I9HGKLtoHW/o6LTGsE2XKT8nfE6zQaHTjsmO8ZLMdBduFkrkrmBRs1n0Z0Q3uDHySBMIubugGQJt/lw9Pfdoqb/ueSkHz1WsBQlVGTyonqLgsIGqncAqQNMtNjxcX92e1wI+u+t9zrBk2LDqChSiN+LnGPyFUJ2H+tEcxalNQzHkVq0eH+KX6cWw89LmP3ktMcXaCPpG6UyXyrdsJX4oqqr+KSJOUUO9WwpgSotq0/3IrZl7BGlmfkN6TaXRLs7xCN+kv6s/5eMYj+RAIMus3MVYrJl+EHAh4ZeOIewqHPD48epDfC7bZVSgA6BjAzvAK/+TcRePvmXE3Y 65fKk2sb yi2pExzVn/AtjGSOTEHH0AMrgI6KtmK/HxC6nSTwK+z1snrwUdoWIqvVzkpJp8zO+urGxb6ksTCMPH7B7U1XcC2XHqdgnPhv2huUpBj7/w+YOFY4ByDdQEfURnMJpcMq+Lhb7c1AjVJzehkmKBbOuxqz5NOV2fnXX76EPGb+4dcoHGWDvNb0svsnVYimaobndA33aUWAGKPoNuc386cExXk5qcGFfEwRnlj/PK0T8xUbJF1rDgXrQOTSf7J/bfy5F+XiS9E5SWE7L4Cz1geLxwziWsI2pRIhwZTs1Xmn4b9abVk2lGyPZgB1TN9qwABkKbwQqkQpymwGVyCx1FGzgp8RBpQuG6R0HdZUX0qCUjiR8/4bwth9kn1v9hiYbj1374ygO8xNgRHv5gwmPl1wHOPXdWBBbLS5y9twdyWxt8Zzjd2WGEHRyT6jJAlSqA96IMQM3F9iLppZOoQjnvYytpAL2rfPbmDDW1DUkuyauyS3EOUHeDtjVIHG1hYkFWSpvOMPu3hDc+E2Hr3HWsn4cjBIhqG22/rzDrwajB8nE+dBkjXNTCUC2l6whl5SORI/pVoa1x1dHs0vxU1I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000321, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 12:12, Li zeming wrote: > The pool pointer variable gets the kzalloc_node function return value > directly at definition time, which should be more concise. > > Signed-off-by: Li zeming This looks pretty useless as a change, the generated code is going to be the same before/after, it is also not more readable, and it is definitively not an optimization in the sense that optimization should be used as meaning: the code is more efficient after that change. -- Florian