From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 649B3C433EF for ; Tue, 1 Mar 2022 15:29:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B13ED8D0002; Tue, 1 Mar 2022 10:29:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC2508D0001; Tue, 1 Mar 2022 10:29:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D9448D0002; Tue, 1 Mar 2022 10:29:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 8FD3D8D0001 for ; Tue, 1 Mar 2022 10:29:23 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3DCD59D640 for ; Tue, 1 Mar 2022 15:29:23 +0000 (UTC) X-FDA: 79196201406.27.A82B679 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf16.hostedemail.com (Postfix) with ESMTP id B677918000A for ; Tue, 1 Mar 2022 15:29:22 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id t11so18787493ioi.7 for ; Tue, 01 Mar 2022 07:29:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JLpzyiylffXpYKOI4/wAJpbR1EAOvSqSarR62ILfzxg=; b=h/wWCF7mJ71VhkAmufHh/jZRBTnW8Ap+8K0IssvuDfBRN/sRD4jRPUFLvR6LmX84e9 GswDevPUad3Q4j2uZ2lre3MssU18K2ziQWstwFFOCKPyTqG0uDg8EFFEQ2SM8tVb1jIN TykcNl20dBaBkYEzkHTvxxQSyK5anbq4ZVe+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JLpzyiylffXpYKOI4/wAJpbR1EAOvSqSarR62ILfzxg=; b=7hmjw2mm/RbcLgAk+D7L8PCUXNerAyqeesLLU8G/TlRRIydJwGWaNNj3ST97jUgVf1 REI6EVP9Buo1PGgFHmxU/AC80TqbLO35yFm3bM8gJa8OrxKsGegI4dSObNMdg+GUbMkM K802F4HWEgnGY5UV1bjPOarwiB/imgIwPv8xtzs+6B7d0i3OMEiNMjVmmS1ZCmOtNKg7 DYZZ3c4xlGsFAN/B3KyGglnu0hM6V4kPn9op1y51DY7CbZJvSEt3j6WdFTVlJxUUieBD UXEFgQvx8fPrpBZfxSqBHr/WO8l6cqTBxN+HMQZPaNcQJupnOMBJICXlRCAgBTKp9i3j ogeg== X-Gm-Message-State: AOAM5317g5i1mpfaPV+Z/AVkywrqragVhyhlSOMnas4uiABf2mkLUqiU KbsAfw1uVnH+iihxJk7o7LI1lg== X-Google-Smtp-Source: ABdhPJyItWAaR2S2fFhZiwhlqaYDrGakTJS0a+yeNdq+94aUuWcwG7Z8OmCFwTybYus7Kg+BORZ8Mw== X-Received: by 2002:a5e:df41:0:b0:642:8c0:ce78 with SMTP id g1-20020a5edf41000000b0064208c0ce78mr18726025ioq.142.1646148560263; Tue, 01 Mar 2022 07:29:20 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id i16-20020a056e02055000b002c2877213bdsm8118473ils.3.2022.03.01.07.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Mar 2022 07:29:19 -0800 (PST) Subject: Re: [PATCH] selftests: vm: remove duplicated macro and use swap() to make code cleaner To: cgel.zte@gmail.com, akpm@linux-foundation.org Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, "Lv Ruyi (CGEL ZTE)" , Zeal Robot , Shuah Khan References: <20220301014404.2052655-1-lv.ruyi@zte.com.cn> From: Shuah Khan Message-ID: <9d6ae3b1-3f36-8196-c136-fa2d07dbca5d@linuxfoundation.org> Date: Tue, 1 Mar 2022 08:29:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220301014404.2052655-1-lv.ruyi@zte.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B677918000A X-Stat-Signature: x5sjgi8w67m4trtp1ur9fm9p8mjcx5xs Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="h/wWCF7m"; spf=pass (imf16.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.41 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1646148562-146148 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/28/22 6:44 PM, cgel.zte@gmail.com wrote: > From: "Lv Ruyi (CGEL ZTE)" > > The macro is duplicated, so remove one. And use swap to make code cleaner. > > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi (CGEL ZTE) > --- > tools/testing/selftests/vm/userfaultfd.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c > index ab394e6bff43..100f08362164 100644 > --- a/tools/testing/selftests/vm/userfaultfd.c > +++ b/tools/testing/selftests/vm/userfaultfd.c > @@ -121,9 +121,6 @@ struct uffd_stats { > #define swap(a, b) \ > do { typeof(a) __tmp = (a); (a) = (b); (b) = __tmp; } while (0) > > -#define swap(a, b) \ > - do { typeof(a) __tmp = (a); (a) = (b); (b) = __tmp; } while (0) > - > const char *examples = > "# Run anonymous memory test on 100MiB region with 99999 bounces:\n" > "./userfaultfd anon 100 99999\n\n" > @@ -1424,7 +1421,6 @@ static void userfaultfd_pagemap_test(unsigned int test_pgsize) > static int userfaultfd_stress(void) > { > void *area; > - char *tmp_area; > unsigned long nr; > struct uffdio_register uffdio_register; > struct uffd_stats uffd_stats[nr_cpus]; > @@ -1535,13 +1531,8 @@ static int userfaultfd_stress(void) > count_verify[nr], nr); > > /* prepare next bounce */ > - tmp_area = area_src; > - area_src = area_dst; > - area_dst = tmp_area; > - > - tmp_area = area_src_alias; > - area_src_alias = area_dst_alias; > - area_dst_alias = tmp_area; > + swap(area_src, area_dst); > + swap(area_src_alias, area_dst_alias); Where is swap() defined? Does this patch compile? I reverted a change like this one reported by Zeal Robot recently. Let's make sure this change compiles and runs. > > uffd_stats_report(uffd_stats, nr_cpus); > } > thanks, -- Shuah