From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187C7C6369E for ; Wed, 2 Dec 2020 23:39:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 70BC6221EB for ; Wed, 2 Dec 2020 23:39:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70BC6221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F74E6B005C; Wed, 2 Dec 2020 18:39:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57FFC6B005D; Wed, 2 Dec 2020 18:39:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46F936B0068; Wed, 2 Dec 2020 18:39:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 2C7106B005C for ; Wed, 2 Dec 2020 18:39:12 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DDD898249980 for ; Wed, 2 Dec 2020 23:39:11 +0000 (UTC) X-FDA: 77549960502.10.pan90_031265d273b7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id BE03516A0D2 for ; Wed, 2 Dec 2020 23:39:11 +0000 (UTC) X-HE-Tag: pan90_031265d273b7 X-Filterd-Recvd-Size: 2617 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Dec 2020 23:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606952350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iOY+ua6LPPG5oekDwz+/gTzCdxqCxzuOLrGK0RqQFSU=; b=N5qyAhaaEn4CzbNpPn5x8T/yDl9pKhQDiiuarziNxaC3PtqNtz15g6+YOfj02TAPsaDlUD NFv2K3rhktKFVjWuDb+EqECbI8FEA/t+K9WyDmT6ntTqfoedZ3Pf4cmI3x4XXkLQqEgOAr mDddssSRuulVv0+FKt3vR3wAm9Ka6Vo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-3NaYKUlPNz-6W4_an8MlkA-1; Wed, 02 Dec 2020 18:39:08 -0500 X-MC-Unique: 3NaYKUlPNz-6W4_an8MlkA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6BB7809DC3; Wed, 2 Dec 2020 23:39:07 +0000 (UTC) Received: from ovpn-66-132.rdu2.redhat.com (unknown [10.10.67.132]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EDDA60854; Wed, 2 Dec 2020 23:39:07 +0000 (UTC) Message-ID: <9d854812b07d8a7516274ea47739158c34cfce08.camel@redhat.com> Subject: Re: [PATCH] mm/swapfile: Do not sleep with a spin lock held From: Qian Cai To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Wed, 02 Dec 2020 18:39:06 -0500 In-Reply-To: <20201202151556.01077710acf79f6fd2ba8287@linux-foundation.org> References: <20201202151549.10350-1-qcai@redhat.com> <20201202151556.01077710acf79f6fd2ba8287@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2020-12-02 at 15:15 -0800, Andrew Morton wrote: > On Wed, 2 Dec 2020 10:15:49 -0500 Qian Cai wrote: > > > We can't call kvfree() with a spin lock held, so defer it. > > > > Fixes: 873d7bcfd066 ("mm/swapfile.c: use kvzalloc for swap_info_struct > allocatio > n") > > Do you think it's worth a cc:stable? IOW, is this known to ever > produce a warning? Yes, it did trigger a might_sleep() warning.