From: Mike Kravetz <mike.kravetz@oracle.com>
To: Liu Xiang <liu.xiang@zlingsmart.com>, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
liuxiang_1999@126.com, Pan Jiagen <pan.jiagen@zlingsmart.com>
Subject: Re: [PATCH v2] mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus_pages()
Date: Thu, 19 Nov 2020 10:34:19 -0800 [thread overview]
Message-ID: <9dbafb55-a1f7-7f6e-d0e9-00dfabc8e2b6@oracle.com> (raw)
In-Reply-To: <1605793733-3573-1-git-send-email-liu.xiang@zlingsmart.com>
On 11/19/20 5:48 AM, Liu Xiang wrote:
> On 64-bit machine, delta variable in hugetlb_acct_memory() may be larger
> than 0xffffffff, but gather_surplus_pages() can only use the low 32-bit
> value now. So we need to fix type of delta parameter and related local
> variables in gather_surplus_pages().
>
> Reported-by: Ma Chenggong <ma.chenggong@zlingsmart.com>
> Signed-off-by: Liu Xiang <liu.xiang@zlingsmart.com>
> Signed-off-by: Pan Jiagen <pan.jiagen@zlingsmart.com>
>
> ---
> Changes in v2:
> as suggested by Mike, apply the same fix to the related local
> variables in gather_surplus_pages().
> ---
> ---
> mm/hugetlb.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Thank you,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
prev parent reply other threads:[~2020-11-19 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 13:48 [PATCH v2] mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus_pages() Liu Xiang
2020-11-19 18:34 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dbafb55-a1f7-7f6e-d0e9-00dfabc8e2b6@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liu.xiang@zlingsmart.com \
--cc=liuxiang_1999@126.com \
--cc=pan.jiagen@zlingsmart.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).