From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89FD5C27C4F for ; Sat, 29 Jun 2024 06:20:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87C846B0082; Sat, 29 Jun 2024 02:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82C8F6B0083; Sat, 29 Jun 2024 02:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CD816B0088; Sat, 29 Jun 2024 02:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 537576B0082 for ; Sat, 29 Jun 2024 02:19:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C8D04A2988 for ; Sat, 29 Jun 2024 06:19:58 +0000 (UTC) X-FDA: 82282925676.30.4A7AA3B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 94866A0021 for ; Sat, 29 Jun 2024 06:19:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gAVQFiwA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719641981; a=rsa-sha256; cv=none; b=nwkVzIpgRrdXCBC70zVq2P6eY3NhXG05N5fPy3f9VDjhKTV9N6mSZU0y1PK+ML+Dk/7Q1Y BzXZJS82LX2dtB1HV6PSXLoFsf508NKIkKKK+3oFfaSfjA0/4nC5eqWwKOLnFqpIEFpEi5 lz090hvP/RN3KksNi694mZ1BgtY+PWo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gAVQFiwA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719641981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eY6MLWt1N9z+CsXSpUZSW3CHxRdj/mgAXfZr6flFdls=; b=akJxklQLoYWw1e3q/eZQInIFZcFPGC3WppXTsSSxXz+G1gHWRqM1Y2V7+DQKxZA2xAjTme u6McbuURj3jr9AjpNqFJXKItR3xZo0EKOyGsHPG8FCoefjE0wUG8l/0tCBmwOLqYq9Ko/L y3JWfb3Rwv//XoBK+PA0ziEB7GaIlH8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719641994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eY6MLWt1N9z+CsXSpUZSW3CHxRdj/mgAXfZr6flFdls=; b=gAVQFiwA0kuMLWmvH4Z1+oAXUt5/zc1MzqO366x0M5HbcupzM47FiEkTCraKPuMwqs/g73 Uox/oMvGLN8u5R6JyUmp3pF0LT64dmieVRDcG9WshSVLkoQ4u/QnTY8f1xryVxrJn8exiw 0P1goLl772bKK8gLMGRe2ghipNSbB7w= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-H7X3FiOsOQ-Opbc4hQt-6Q-1; Sat, 29 Jun 2024 02:19:53 -0400 X-MC-Unique: H7X3FiOsOQ-Opbc4hQt-6Q-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52cdec8a6a7so1231712e87.0 for ; Fri, 28 Jun 2024 23:19:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719641992; x=1720246792; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eY6MLWt1N9z+CsXSpUZSW3CHxRdj/mgAXfZr6flFdls=; b=G3qTSzfgVy3Ryn0j/P0SKpC9B16jepYfrBXFY35Pj9BgvMzac0SwSd03nE+JdDrmBE PgHOxZv6lkgQhhhRU9BE7MeEJLs1ztUCHIccZHeIK08Je/HUx91MOtxoIgl49Anq2tRe r3UQolDFrYJD0FG+NjElwbi7QdIaZi8GIXeLPcuutsQXewlF5PITM4e9zjc7FqNxjrEz fY9qOrlp/ZzIBvSDa1y0x5yVmUjBYxgThAADOWQIToz6syua6mX63WnEnxCHbho09Net dad9Sujk4GmOGeBp4xMCzo6wTmtGW5o4cuEKJUQQZdw4FJx8vYShBTzwHMFUZNOW2SLw JX2Q== X-Gm-Message-State: AOJu0YwX7Tus7/HRpFyLY1RWMcI5HQfZ0pfpxLZl755xME7o3fhsip48 ZKfykChVoonhJpNsZDvunutcKdOyryJr0pNd1DlPLKge++Iu5CUaE3ZPeyzxf7gG5ybBttLYQj1 iR6QLKYnKcYIKBKhUTA1DmZmQENXdnjl4E2pyznioFTF5ZkUV X-Received: by 2002:a2e:a178:0:b0:2ee:4623:173 with SMTP id 38308e7fff4ca-2ee5e36c2fcmr2374411fa.14.1719641991766; Fri, 28 Jun 2024 23:19:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgdJC/LYjdxijbWTpcmb7bJEw33jKPOmIxHKSV9EV17N19cm+DCrBfo8kcZ+hGv6a6/s+wSA== X-Received: by 2002:a2e:a178:0:b0:2ee:4623:173 with SMTP id 38308e7fff4ca-2ee5e36c2fcmr2374251fa.14.1719641991299; Fri, 28 Jun 2024 23:19:51 -0700 (PDT) Received: from [192.168.1.34] (p549c4067.dip0.t-ipconnect.de. [84.156.64.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4257a4d4cd1sm1129615e9.28.2024.06.28.23.19.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jun 2024 23:19:50 -0700 (PDT) Message-ID: <9e05d9da-36bd-4094-93d7-1c19eb77df1e@redhat.com> Date: Sat, 29 Jun 2024 08:19:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: not __SetPageReserved on initializing hot-plugged memory To: Wei Yang , akpm@linux-foundation.org, rppt@kernel.org Cc: linux-mm@kvack.org, Nathan Zimmer References: <20240629013322.12364-1-richard.weiyang@gmail.com> <20240629013322.12364-2-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240629013322.12364-2-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 94866A0021 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tyxtsikoanb1o9ztqd7hn44y3nsp8rym X-HE-Tag: 1719641995-776275 X-HE-Meta: U2FsdGVkX1/G8E+aBiezkxnMvQBGcGKyPZmXLPlpEBkQC7zR/nd3zjhGFInHYkETNr0rFyYhGhOwXEABa4H3wj2D+fe4tlTnejFXhBoBNWU6XtsXkIzZHnQkgt6cVaacju+2JFSHOIUJCaBcewOzf2ZXsGbfgVKwcJ32uit0x2xEBy14OKWcZ4VyswHa7Y80Om5qGaJFpbDZEl+3tpfNWXNcCDtw52u0DBD3nXYMj2yjhEuvosCFB3UAKW54/L5+2880RZ0iAGoBao+lx9mm4lLCCZUZyXY/NtZ2RhxPcBhMhR8IR52yNKRYTm1TKfQqIoNK4YdvH8B1bzRmDUworVk3uaVXqxBrbnTdpLeBANGquaMli1ntpaeHbTtBaS1JnrBJigkhOyAC0JE0kHLQ7xxAGxwep9mX8Klfw/7JhhLvHU/YvO728JfapzPYM+8V9gOn1o+VOWGFf6ygNV1xCJ1k+099A19n6+BI2TPTHByr5KmzqyQyW3VCp/B479IsK0BBSLlVMZWvFAlug1b+my/8euvPi0GgWlOdWK5+bp78Nh4F3nJEFxbOPZ/4IT26coXZQZ0irEHDkDtrFXr/z6RVLOTOSoW7aa6d2d0ZIND5NH56w40Ygf0KRRZS/4DHvmVbYo9fFo+MpMLsUxf3xPCWw1TNErVi1Ay4JSoULd6WcLalVzsD+Bw4Yl0nV3VwJlK/6si0IoQ3J9Q1IS3NPsUTFZu8AfZ96L/x9ij3hTdmt+ft5oCstJRuR0NwsYVcUFcpSfy4Csod2kAeiSuh32KsUuF8BJeBNxxTZikl7bXlwCyXvrB6cBhcxEJp2P7fbK4sseZi+DgUHhDEMnV5wDUyieFq52UcLdlh+GXutQYh/hcsXKfhunmn5TVyOMbhF9tdorHm/6EqUKYuxtu9LhP5Wxz0jcFLRDa19UAjYlkEPLojWJ8YKKrEV65YunYJT7np/seSeQLYBxMxaZe Uz0L2AFr JZ1WPOiE91HFz3VXK33PmR0u01O3mwkRK5u8qQOUWNSLVk3bKLVZX/IOP9zRiFw0HJeAKnfhwoMsb54wQIRv6Q89sOjODwA8df5s5JPcBSkrnM2LMRDZYYZGIoLBH4eSp0vlFznniQvdIzhevsFKtjKNUBaQ5GsdP55a8tv4o3Yq+xgKhXybrv7N98MloIT64y8SbhU8khdbvCnnZcG9dLXVOEDPSaEp99B51O+RNu8qAfXyIMXmePSclXfgs7hkRyHdO96k9ncjbpN+lXVsselL/kiC7X2iuj6BjS8GtkI4isg7/cPZmXthe2Brjeae6msSm6gl1gkmIDYlJgsYHrBu1UEP3tfWHQFqQ7njO6dJfaBpngeFuwlOhsTVtdODuxfRUyqvH2B0V/cM/ROw8afFvqQvAIaChvgB07L3KxX/+1xtNZjC6cltt4l+cBLyk1Z4Ea+erWaheWO2paha6GJnzaA6jGyWf0CiR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.06.24 03:33, Wei Yang wrote: > Initialize all pages reserved is an ancient behavior. > > Since commit 92923ca3aace ("mm: meminit: only set page reserved in the > memblock region"), SetPageReserved is removed from > __init_single_page(). Only those reserved pages are marked PG_reserved. > > But we still set PG_reserved on offline and check it on online. > > Following two commits removed both of them: > > * Commit 0ee5f4f31d36 ("mm/page_alloc.c: don't set pages PageReserved() > when offlining") removed the set on offline. > * Commit 5ecae6359e3a ("mm/memory_hotplug: drop PageReserved() check in > online_pages_range()") removed the check on online. > > This means we set PG_reserved for hot-plugged memory at initialization > is not helpful and a little different from bootmem initialization path. > Now we can remove it. It's not that easy for ZONE_DEVICE. Also, see mm/mm-stable commit 3dadec1babf9eee0c67c967df931d6f0cb124a04 Author: David Hildenbrand Date: Fri Jun 7 11:09:36 2024 +0200 mm: pass meminit_context to __free_pages_core() Patch series "mm/memory_hotplug: use PageOffline() instead of PageReserved() for !ZONE_DEVICE". commit b873faaa609ab44c223b2327f55d2b6a2ba4ca9c Author: David Hildenbrand Date: Fri Jun 7 11:09:37 2024 +0200 mm/memory_hotplug: initialize memmap of !ZONE_DEVICE with PageOffline() instead of PageReserved() If you want to work on removing it for ZONE_DEVICE, one idea is to replace all relevant PageReserved() checks by a more generic function that would check PageReserved() and the zone -- Cheers, David / dhildenb