From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 055AAC433FE for ; Mon, 7 Dec 2020 07:24:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E96621734 for ; Mon, 7 Dec 2020 07:24:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E96621734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 41D3F8D0005; Mon, 7 Dec 2020 02:24:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CD018D0001; Mon, 7 Dec 2020 02:24:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E3C88D0005; Mon, 7 Dec 2020 02:24:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 153248D0001 for ; Mon, 7 Dec 2020 02:24:57 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D0DB2180AD807 for ; Mon, 7 Dec 2020 07:24:56 +0000 (UTC) X-FDA: 77565649392.12.jar75_35065fd273dc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id AAE401800C876 for ; Mon, 7 Dec 2020 07:24:56 +0000 (UTC) X-HE-Tag: jar75_35065fd273dc X-Filterd-Recvd-Size: 2227 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Dec 2020 07:24:56 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DD949AC9A; Mon, 7 Dec 2020 07:24:54 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 07 Dec 2020 08:24:54 +0100 From: Oscar Salvador To: =?UTF-8?Q?HORIGUCHI_NAOYA=28=E5=A0=80=E5=8F=A3=E3=80=80=E7=9B=B4?= =?UTF-8?Q?=E4=B9=9F=29?= Cc: Vlastimil Babka , akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams Subject: Re: [PATCH 3/7] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED In-Reply-To: <20201207023429.GA8986@hori.linux.bs1.fc.nec.co.jp> References: <20201119105716.5962-1-osalvador@suse.de> <20201119105716.5962-4-osalvador@suse.de> <2aa4bf71-443b-9b9b-b761-12761263dfec@suse.cz> <20201201113511.GA22242@linux> <840d4669-ae3f-b7c4-6132-e20d1bf9e952@suse.cz> <20201205153423.GA4108@localhost.localdomain> <20201207023429.GA8986@hori.linux.bs1.fc.nec.co.jp> User-Agent: Roundcube Webmail Message-ID: <9e15f4980654717f52733c56c33a3bdd@suse.de> X-Sender: osalvador@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-12-07 03:34, HORIGUCHI NAOYA wrote: >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 869ece2a1de2..ba861169c9ae 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -1269,6 +1269,12 @@ static int memory_failure_dev_pagemap(unsigned >> long pfn, int flags, >> if (!cookie) >> goto out; >> >> + if (flags & MF_COUNT_INCREASED) >> + /* >> + * Drop the extra refcount in case we come from madvise(). >> + */ >> + put_page(page); >> + > > Should this if-block come before dax_lock_page() block? Yeah, it should go first thing since as you noticed we kept the refcount if we fail. Saturday brain... I will fix it. Thanks Naoya -- Oscar Salvador SUSE L3