From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DFBC4345F for ; Mon, 6 May 2024 01:38:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5801E6B0083; Sun, 5 May 2024 21:38:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 508CC6B0085; Sun, 5 May 2024 21:38:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 383AF6B0087; Sun, 5 May 2024 21:38:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17DE16B0083 for ; Sun, 5 May 2024 21:38:38 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B6F3F405D7 for ; Mon, 6 May 2024 01:38:37 +0000 (UTC) X-FDA: 82086261474.19.D437430 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf10.hostedemail.com (Postfix) with ESMTP id 3A298C0002 for ; Mon, 6 May 2024 01:38:34 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714959516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOh2DNq/ALKOxEFuNcYkdDLDowhusytPK/KkdWzJoKI=; b=sAcBTLMMPVSQ4PyWfGuEfiGm1GdydxInhFIsClESDPcGfdAcIaJCC1yKvQWYY1VlcuaueC xVBcWMX9v+gynCA0WYY7PWtINyWLydOdcPTEkZkYnkM7JabYudkCd0G+p7SXNwq94Yx1K6 4K6ph7GU40lYiZOMNW/WD8YoHGvVGdI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714959516; a=rsa-sha256; cv=none; b=b2aLtRtbx7G6gaFBgW78OZ1zdoXCF6WVAFtr6WklVmc6SP0EtffstsH/nwFTWloNMFgevS pL3xMdmCYMfnvsVG2QLbdD5E1In5lkdFKuX9tpNO6ldVHUFD/S7ZmbYJGw/BXa3bfPigYE 3eVUjuF2KBc5zZbOAvIF5lxGDh679pI= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VXkZN69fZz4f3lgR for ; Mon, 6 May 2024 09:38:20 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 983361A01A7 for ; Mon, 6 May 2024 09:38:30 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP1 (Coremail) with SMTP id cCh0CgDX8QqWNDhmj06CLw--.5810S2; Mon, 06 May 2024 09:38:30 +0800 (CST) Subject: Re: [PATCH 06/10] writeback: Factor out code of freerun to remove repeated code To: Tejun Heo Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-7-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: <9e18efb9-881e-d8ee-4acf-5e05f4c223ea@huaweicloud.com> Date: Mon, 6 May 2024 09:38:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgDX8QqWNDhmj06CLw--.5810S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUU5R7kC6x804xWl14x267AKxVW8JVW5JwAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII 0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xv wVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4 x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG 64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE14v26r 1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vI Y487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UX4SrUUU UU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Rspamd-Queue-Id: 3A298C0002 X-Rspamd-Server: rspam06 X-Stat-Signature: wzzb9sd448ojsqbf5enx98abqec5csc7 X-HE-Tag: 1714959514-437047 X-HE-Meta: U2FsdGVkX18DjG93tXG4v2SQDRUeI5HM5hJuSSbe9AbUlJejxV6Q0y7XYJAnOKm7F2q3Ea31rqvTzog89V846GRZHdfyCjvTIk7AWCu8ZrDTM2NBRWl2cmT0lBEcNftz6cVJz703VVUXCSmErK9QDWfMfhIK27QPL1HBCnd+iOhIE25OFeQjSjeh616x+9SO3Z03hHQGbE/tBpXexGdX0WzrP5ujVpMgAMbH1I7TNWk7RmGJiVvzlki+WY2yTJv1OOSA4b0LLGXMv7I89EBwg779uLtEUmoX4pm9KGItriTHUwNhZmiAwlN/16LRiPUgbYKIAy8Hk8YgG85tYNVG3F7TCEt42iberlLAJNsmxIGIeWxWc4frWytzqaPYjMv/7xuTpqOTMscauURTaswU3LEct7qYy94eNtihhJ1qabpwFarUyg6YNzLD3ba2rIIvUULfSpqdsK4rM5X9m5UshsRU0WmswKXlaFmXXXWruA71fl5YUv+hr8MAofZk9dIVvqy12DmOgWjMm8lFZnaT41w9717auS/bDAo6JJQW9zrJc7zFtjuLKoXgixvVvPr2DE9jV3fiNFBIM5e74ewpEAN1zMHnnPeKXX3tCBAqJGUlPnY9nRzC99qmevt4Tb/C6ygFiWx8RzE9tnbOllidjIIJz9PNEAgiTZemJcIfHreghdLpc+psNvxAl6j6YWQVHBS7NiY0Erd2G8bf/NvqazCXkE/aCvwDwOL3Z++L/j0bkBTxIJ3VPIWArYv7zxm9l1FqqQiXOdLP1xA7dFJjEceEyU25bn09XHSGPtwBFO2NWNNAgTlucQfFxZ6cE5rcNT7DtNbQwDhmkeqbYFWLBkWj6gkg7JZXB8uP9G03rk2usyfVZuS5WNplcg1en5KbCDxbLswnYw7sQcf7XNt6PhLgYEFkyMHvPETVpeesYrgHNh2X+XIwDL6eRGDF62gXU2eSLNxGdRN/s2OTfaC 2bS7n7mG JzDWfwt6g7MdOQFfuwfDtUvhUGu6JIGx8yVybmZNf661NEQUX37HMGrmKG9ceeUrFT5MTL/IptHHaQFEwyE6NCRokb1XEBmzWaYGqMEOBdyUH0WIolJ67bxxz5X2sKJaQLSkPjG/8YvSaZH3sH4hdLbXWzMrqjftEDu+2ohDrG4GgcF0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.053983, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 5/2/2024 1:15 AM, Tejun Heo wrote: >> +/* >> + * Throttle it only when the background writeback cannot >> + * catch-up. This avoids (excessively) small writeouts >> + * when the wb limits are ramping up in case of !strictlimit. >> + * >> + * In strictlimit case make decision based on the wb counters >> + * and limits. Small writeouts when the wb limits are ramping >> + * up are the price we consciously pay for strictlimit-ing. >> + */ > Can you please reflow the above to 80col or at least seventy something? Sure, will do it in next version. Thanks.