From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FFBC38142 for ; Fri, 27 Jan 2023 05:40:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 133AC6B0072; Fri, 27 Jan 2023 00:40:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ED626B0074; Fri, 27 Jan 2023 00:40:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9F918E0002; Fri, 27 Jan 2023 00:40:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D38716B0072 for ; Fri, 27 Jan 2023 00:40:42 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ABFAE40327 for ; Fri, 27 Jan 2023 05:40:42 +0000 (UTC) X-FDA: 80399479524.16.C41675D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 2185710000D for ; Fri, 27 Jan 2023 05:40:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MrU8dC9+; spf=pass (imf14.hostedemail.com: domain of leobras@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=leobras@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674798040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FWxdO0MtuPmeNg9daF/UvmuWggIxtoYm3xMVJgvRbE4=; b=Fxih4IkUsguqbtYum896Ln2RGiQFxk7g5YbiTx0Af4mQIb+nqL9UisWEUNHO/p77ghxrNN tG6tHFEQJMoHjUFtkNbCFFJ30ZHzeVuyHVKOwWGf4CWUUfqlB1+0euiElvp4F0NOIzs53Q oo2Del5bVIkcEJq8UswuhEkG1KHu9CQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MrU8dC9+; spf=pass (imf14.hostedemail.com: domain of leobras@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=leobras@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674798040; a=rsa-sha256; cv=none; b=fe9VSdVTdyTT4P0TSDY4lBX/nON9RaOVLKD61BwdShGWnT5qiQBxamHVUkCggFdwy77Ew9 dWINaFmGNpOWe/MwTrc797JH8LptumknvAFnUoLjNMsbK0AJo5UF83XleD60K2TV++Uk25 ZDgyEEcqCNOtkSyDf7Bl3HuYS3XDxnQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674798039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FWxdO0MtuPmeNg9daF/UvmuWggIxtoYm3xMVJgvRbE4=; b=MrU8dC9+eXoJGzupidsa17e+tEdoDvHz4IgGejE1g2aCd8q4O2h9KNVv5rmKBxgKLBcBJ4 ihTe4jN/OePoBomN2a7uobHM9srr9eEKAfsgBlQPsLrxMVCBRDyfkaqha0Ob0m+fE5Tc8v +rAjp4msx8YHAmp1DRQzuKVMe35lQfw= Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-614-kTwStfwpO_ilV_dH1VFrsA-1; Fri, 27 Jan 2023 00:40:36 -0500 X-MC-Unique: kTwStfwpO_ilV_dH1VFrsA-1 Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-1634c8f8b54so1327882fac.14 for ; Thu, 26 Jan 2023 21:40:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1/nlRzFE8uEH2KN6NvFa3jRsSiNKHTj9vX5XMb/Z35s=; b=AH/LmRSFkUkLAzIhUYWz59CfDNCuYr69blSk5YUpDgGMzyIREN4Qv/vQJ3cTByzFtZ IiZOtnQH/zDGOxfEQhXAUyfSVp5XCUA+7Ce/KxZ1BbobGMzdugL5JhVGrQiAPjyBPOzH 95cYfg3XlwqR5vxCYNfb3AIokWZqr0GOs499XoM6vaVbmn0mpGl6gtQWca905kX7KWi8 eAQ4chWJTkpu14ry4CIRDbXqN/kBKnQulKNcPHoSihHgV+BHVkJb08B4FG2eh/3VmhOy V69c0GB4j4g3jilf36iTPhxOEfKQEcv3ikA4c+QFQNGZPEqzTKeUGY97/xnvYLe7JPbB XzKg== X-Gm-Message-State: AO0yUKVt0bXBvvCy0Dlf9p5vwlxZTZ83+Txax7d4fd7j/DdOJDMcLrIU H6hijvPIOrUG0iLsMDl4/uk73aJ6GTDAnVfrWzOxt3LdvCnKNDFgsMi+FYicAR/wdtw7FusTFgz IzDVXiEC2mV0= X-Received: by 2002:a05:6871:824:b0:163:6dfc:755b with SMTP id q36-20020a056871082400b001636dfc755bmr747748oap.24.1674798035414; Thu, 26 Jan 2023 21:40:35 -0800 (PST) X-Google-Smtp-Source: AK7set+gOU/E4LLHCIEREuBaAclxcItR+R67IH4Yta6AaWQrnjayQqogFXCB61xcxPBZzjam4UVDAw== X-Received: by 2002:a05:6871:824:b0:163:6dfc:755b with SMTP id q36-20020a056871082400b001636dfc755bmr747738oap.24.1674798035177; Thu, 26 Jan 2023 21:40:35 -0800 (PST) Received: from ?IPv6:2804:1b3:a800:6912:c477:c73a:cf7c:3a27? ([2804:1b3:a800:6912:c477:c73a:cf7c:3a27]) by smtp.gmail.com with ESMTPSA id lg6-20020a0568700b8600b00150835847c2sm1403175oab.16.2023.01.26.21.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 21:40:34 -0800 (PST) Message-ID: <9ec001ba093e21a5ac2cafa1c61810b035daf13d.camel@redhat.com> Subject: Re: [PATCH v2 0/5] Introduce memcg_stock_pcp remote draining From: Leonardo =?ISO-8859-1?Q?Br=E1s?= To: Marcelo Tosatti , Roman Gushchin Cc: Michal Hocko , Johannes Weiner , Shakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Fri, 27 Jan 2023 02:40:28 -0300 In-Reply-To: References: <20230125073502.743446-1-leobras@redhat.com> <9e61ab53e1419a144f774b95230b789244895424.camel@redhat.com> User-Agent: Evolution 3.46.2 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2185710000D X-Stat-Signature: fjzucou3oxjkzwr379hfyxhbtpwrrbd6 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674798039-523785 X-HE-Meta: U2FsdGVkX197CWPnFAHuTgr6egMlCiMHBRtLpMVXh6jcg/mMQAbBvuHLtR3DqEupsPUtY93dQz5sNcb4epF8XAi00WnhqwkGfK3z5Z2b6845mLJaaoJHPiA0foyQuB5lpgmFeK7g9QCtvbzt96a2DlECcjKBIFgWr3fR3QMWP5NeMWwMmK7bpzOV8k3KxqgA77qLSC2K+MHC83voJbrxDuAtHhobSTJkPdsQv03o5vtgjv1JQ5goImHSpPRXk5ahL+w/cqPx9KYzkYZr7L1uEA3dLE292MmIjk/B7BTdJ/qp6CiW7AEyrqLu+V9G6tExwyW2QTTG0jLEa76prIPrL4zOTb/Ru8BFW/dD2maAX0x5BnfGJkbTkJWnAc7EIClEweXCTxmliKs29AqJ84MKs2MZlQ3/12cM29Yc0uZ8yjElh2k9sNGVpUBz5sMzt1J15aAmw9lnnfVGEdtMHzou310NJ3f3boj/xL03vcVh2E/K2dZHwx/q/e9oLadsp7VsG/bpxjGzv0m2Irq7sJt0GEInRsdSD4timID2Ljq7oXYcl/cGIWa697fxnVXWewr1l4LAemhO+EZhXMdLoxK+eiYxe14nDW0Yn6Eq+YQx103d56Cwa2htwdC0PpUM1fPmdIzaAonrBD4mgy7ifgCHgQwvH6fbu9ZUIX9ZzfrADhHhhL073ntU24MfYUevjn0vXB8jPCXoX9bXwacBk+xOhvHibiTedjxUMDqoj5aVSQamXOZkqZpdJ1rQ32fBr0JlYgRJJSWrcZc3lYCPSfAiVlOGSagxuVi4eZB0zOGRssX+0Ezfh9/KWn/L8OdGvSH1quqq86D2IWlpzcUM5NWlnEW+0FaCVQ5PNXVZqeieOlBFWJddLOfjpNEakh0ZWn7pla5R4GYWWfEE9FsK+nDl0gjAilFESJAJyJU+hgAilsjynwgWd0o/cHEmXKxoMYIExg0vgVoP/gbW/IkZAls g2M/4UuB vr+CeaBjsexdO5bZohWLpvM8HnlUu6WdLkvkj4flyIc9BYN7B1mjkLkdeSGZPfzeH7JciaiTooz/tAtLMTvCpigdz63OkR6So12618XzBXaDeiLvWFsOHns+if20GEPvtHlfFlqvq0mWQPMpT2xxHkw4s++86SCd9XFtQUFnxIyE35+vfoJfIe8mvyKjoVnYeLOMOug/bPojbpGl8ugQ8UKSc1iynhgOg7FU32RddEZAXqetBAl057e1otdGCsedAlizwxQnNEoU/DHuDEORgdDjNJOhCfnChYfata+pQclGNH49SBjcKbL3dk8z6h/mrxNgKGXq86AgXOS2JhUKbF8IPF0Pydvv5cjlk1/gHrZwO2Ty07n6DMinxXp68zAIZa+VYwSDF5vdH9CsF4HJ2w5Dprk7FE6E/1olsumskKIV/w84pzGt6dadzcfTZO6/wT/rv26K76+yGmkfsrS3xAoH3q+jFqlRz5uWhM2Y6m3OFUuKU8EWzVb4cNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-01-26 at 15:19 -0300, Marcelo Tosatti wrote: > On Wed, Jan 25, 2023 at 03:14:48PM -0800, Roman Gushchin wrote: > > On Wed, Jan 25, 2023 at 03:22:00PM -0300, Marcelo Tosatti wrote: > > > On Wed, Jan 25, 2023 at 08:06:46AM -0300, Leonardo Br=C3=A1s wrote: > > > > On Wed, 2023-01-25 at 09:33 +0100, Michal Hocko wrote: > > > > > On Wed 25-01-23 04:34:57, Leonardo Bras wrote: > > > > > > Disclaimer: > > > > > > a - The cover letter got bigger than expected, so I had to spli= t it in > > > > > > sections to better organize myself. I am not very confortab= le with it. > > > > > > b - Performance numbers below did not include patch 5/5 (Remove= flags > > > > > > from memcg_stock_pcp), which could further improve performa= nce for > > > > > > drain_all_stock(), but I could only notice the optimization= at the > > > > > > last minute. > > > > > >=20 > > > > > >=20 > > > > > > 0 - Motivation: > > > > > > On current codebase, when drain_all_stock() is ran, it will sch= edule a > > > > > > drain_local_stock() for each cpu that has a percpu stock associ= ated with a > > > > > > descendant of a given root_memcg. > >=20 > > Do you know what caused those drain_all_stock() calls? I wonder if we s= hould look > > into why we have many of them and whether we really need them? > >=20 > > It's either some user's actions (e.g. reducing memory.max), either some= memcg > > is entering pre-oom conditions. In the latter case a lot of drain calls= can be > > scheduled without a good reason (assuming the cgroup contain multiple t= asks running > > on multiple cpus). Essentially each cpu will try to grab the remains of= the memory quota > > and move it locally. I wonder in such circumstances if we need to disab= le the pcp-caching > > on per-cgroup basis. > >=20 > > Generally speaking, draining of pcpu stocks is useful only if an idle c= pu is holding some > > charges/memcg references (it might be not completely idle, but running = some very special > > workload which is not doing any kernel allocations or a process belongi= ng to the root memcg). > > In all other cases pcpu stock will be either drained naturally by an al= location from another > > memcg or an allocation from the same memcg will "restore" it, making dr= aining useless. > >=20 > > We also can into drain_all_pages() opportunistically, without waiting f= or the result. > > On a busy system it's most likely useless, we might oom before schedule= d works will be executed. > >=20 > > I admit I planned to do some work around and even started, but then nev= er had enough time to > > finish it. > >=20 > > Overall I'm somewhat resistant to an idea of making generic allocation = & free paths slower > > for an improvement of stock draining. It's not a strong objection, but = IMO we should avoid > > doing this without a really strong reason. >=20 > The expectation would be that cache locking should not cause slowdown of > the allocation and free paths: >=20 > https://manualsbrain.com/en/manuals/1246877/?page=3D313 >=20 > For the P6 and more recent processor families, if the area of memory bein= g locked=20 > during a LOCK operation is cached in the processor that is performing the= LOCK oper- > ation as write-back memory and is completely contained in a cache line, t= he=20 > processor may not assert the LOCK# signal on the bus. Instead, it will mo= dify the=20 > memory location internally and allow it=E2=80=99s cache coherency mechani= sm to insure that=20 > the operation is carried out atomically. This operation is called =E2=80= =9Ccache locking.=E2=80=9D The=20 > cache coherency mechanism automatically prevents two or more processors t= hat ... >=20 >=20 Just to keep the info easily available: the protected structure (struct memcg_stock_pcp) fits in 48 Bytes, which is less than the usual 64B cacheli= ne.=20 struct memcg_stock_pcp { =09spinlock_t stock_lock; /* 0 4 */ =09unsigned int nr_pages; /* 4 4 */ =09struct mem_cgroup * cached; /* 8 8 */ =09struct obj_cgroup * cached_objcg; /* 16 8 */ =09struct pglist_data * cached_pgdat; /* 24 8 */ =09unsigned int nr_bytes; /* 32 4 */ =09int nr_slab_reclaimable_b; /* 36 4 */ =09int nr_slab_unreclaimable_b; /* 40 4 */ =09/* size: 48, cachelines: 1, members: 8 */ =09/* padding: 4 */ =09/* last cacheline: 48 bytes */ }; (It got smaller after patches 3/5, 4/5 and 5/5, which remove holes, work_st= ruct and flags respectively.) On top of that, patch 1/5 makes sure the percpu allocation is aligned to cacheline size.