From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E0CCC433F5 for ; Thu, 10 Feb 2022 02:21:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD8AE6B0073; Wed, 9 Feb 2022 21:21:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B39A16B0074; Wed, 9 Feb 2022 21:21:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D9956B0075; Wed, 9 Feb 2022 21:21:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 8CD8B6B0073 for ; Wed, 9 Feb 2022 21:21:00 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 420B4987AF for ; Thu, 10 Feb 2022 02:21:00 +0000 (UTC) X-FDA: 79125267480.10.FB3EA58 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf19.hostedemail.com (Postfix) with ESMTP id D48821A0004 for ; Thu, 10 Feb 2022 02:20:59 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id c189so3467397qkg.11 for ; Wed, 09 Feb 2022 18:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=kxPpYOr9fMCpJd7sCfUn04qJNkl4bMWZoTA8Ys3By8k=; b=BxDabmfDoaUDg1dIy4jDTq+JM5s/45/glUofZdZQaH0DIPhWoBB6gHmDiT2A8DFOva G32ykwm4JiumAeBLNmVBsH3T1FvUvgNfX9W1gelGS4ABinKosCLgG0inBLbTYGLz8uHV /qjKuiTneFLu4RNVWZErq28gjv6qydN2NGQVMd5wNwjeyuC3AeOV5F+X5jMibsRfFJQo AZGztqAZ0+9r1GtckwGOODMrVKec6y1LAdVFCSg6CfzrhO8R5VKvl0F7z1lezAYhBQ0X tYlhMTzDKAFaTDfcajRq4HtNPIMYyxIIOY8054YxUH0GqhY1GsoaRhLaJtl6GfEA3xQP vo1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=kxPpYOr9fMCpJd7sCfUn04qJNkl4bMWZoTA8Ys3By8k=; b=LlXtgD4ZsUTPKldXMXGdpl6hSbN3xZlE9zuMK/+vefzdJ6CkDeFI17pbQ7XpWglKWu sCbhUoZV+VebAhKaU5fx5BAc201dW+oJsuI4IAZ7rEZdg6x95HTPaoZMnfrNbk4C/kot sZYlac6mAmFMhm4fcEM+A566rmA0aHkrnMACC3DBowJBs+hNwQAvLggizfO5nbP00jLa c4FgpluvyXLTH0QVQxXkRBjKqh3VW9up/lA+5CP5I/qhsRtRhCvqzAHvoyGiwL9W/I83 w7cXUv3a2YOa6W0hHHTHyrw1RGygrMY4gLJjEmlcyhR4Ofwtnxz2bLBXWMzJNtvNQnGm /yfw== X-Gm-Message-State: AOAM531eVaqOmmUzC7JbTxncYzuCzV7Ej+w+AnB/PlkI+dAyqRc5Lqqu JDfSJg4UFohI1mmmGgo1l9g5vg== X-Google-Smtp-Source: ABdhPJz7jqG0d7JGpbU68kibD9jbvyBU3iduP2od/KjZDE0+g8Vn/9ABBS1tr25xGzStG9SpUY1rQg== X-Received: by 2002:a05:620a:2904:: with SMTP id m4mr2721558qkp.479.1644459658987; Wed, 09 Feb 2022 18:20:58 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 16sm10185035qty.86.2022.02.09.18.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 18:20:58 -0800 (PST) Date: Wed, 9 Feb 2022 18:20:46 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Yang Li cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot , Hugh Dickins Subject: Re: [PATCH -next] mm/munlock: Fix kernel-doc formatting issues In-Reply-To: <20220210004849.69017-1-yang.lee@linux.alibaba.com> Message-ID: <9eceb01a-4a62-985f-52c-266cabc156f9@google.com> References: <20220210004849.69017-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BxDabmfD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of hughd@google.com designates 209.85.222.181 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: pjjh5c49ix448rwugfnh9t6e7xf3qa4s X-Rspamd-Queue-Id: D48821A0004 X-HE-Tag: 1644459659-557089 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Feb 2022, Yang Li wrote: > Some functions had kernel-doc that used a hash instead of a colon to > separate the parameter name from the one line description. > > Replacing them to remove warnings found by running scripts/kernel-doc, > which is caused by using 'make W=1'. > > mm/mlock.c:218: warning: Function parameter or member 'page' not > described in 'mlock_page' > mm/mlock.c:240: warning: Function parameter or member 'page' not > described in 'mlock_new_page' > mm/mlock.c:260: warning: Function parameter or member 'page' not > described in 'munlock_page' > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Oh, great, thanks. I thought I was just following what was already there, but now I look closer, yes, the ones with "/*" at the top had dashes and the ones with "/**" at the top had colons: apparently I fell for the wrong combination - sorry. Hugh > --- > mm/mlock.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/mlock.c b/mm/mlock.c > index d50d48961b22..7fb97e1242f1 100644 > --- a/mm/mlock.c > +++ b/mm/mlock.c > @@ -212,7 +212,7 @@ bool need_mlock_page_drain(int cpu) > > /** > * mlock_page - mlock a page already on (or temporarily off) LRU > - * @page - page to be mlocked, either a normal page or a THP head. > + * @page: page to be mlocked, either a normal page or a THP head. > */ > void mlock_page(struct page *page) > { > @@ -234,7 +234,7 @@ void mlock_page(struct page *page) > > /** > * mlock_new_page - mlock a newly allocated page not yet on LRU > - * @page - page to be mlocked, either a normal page or a THP head. > + * @page: page to be mlocked, either a normal page or a THP head. > */ > void mlock_new_page(struct page *page) > { > @@ -254,7 +254,7 @@ void mlock_new_page(struct page *page) > > /** > * munlock_page - munlock a page > - * @page - page to be munlocked, either a normal page or a THP head. > + * @page: page to be munlocked, either a normal page or a THP head. > */ > void munlock_page(struct page *page) > { > -- > 2.20.1.7.g153144c