From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Georgi Djakov <georgi.djakov@oss.qualcomm.com>,
akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-cxl@vger.kernel.org, osalvador@suse.de,
gregkh@linuxfoundation.org, rafael@kernel.org, djakov@kernel.org
Subject: Re: [PATCH] drivers/base/memory: set mem->altmap after successful device registration
Date: Wed, 13 May 2026 18:07:58 +0200 [thread overview]
Message-ID: <9f0b2894-ba79-4ef5-8be0-be8f4b5dd3ff@kernel.org> (raw)
In-Reply-To: <fb932d7f-0ba7-415d-ab36-e948d2bbb537@oss.qualcomm.com>
On 5/13/26 18:01, Georgi Djakov wrote:
> Hi David,
>
> On 5/13/2026 4:20 PM, David Hildenbrand (Arm) wrote:
>> On 5/13/26 15:14, David Hildenbrand (Arm) wrote:
>>>
>>> Something does not add up here. How do you get an altmap with virtio-mem?
>>
>> That patch itself makes sense, but the callchain does not make sense.
>>
>> virtio_mem does not set MHP_MEMMAP_ON_MEMORY, so it should never reach
>> create_altmaps_and_memory_blocks()?
>
> I have some out of tree virtio_mem patches on top that helped to trigger
> this. Sorry for not mentioning it. Should i remove the callchain from the
> commit text to avoid confusion?
Yes. You can mention that this was trigger by modifying virtio-mem. But the
misleading calltrace should not be included.
--
Cheers,
David
prev parent reply other threads:[~2026-05-13 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 13:09 [PATCH] drivers/base/memory: set mem->altmap after successful device registration Georgi Djakov
2026-05-13 13:14 ` David Hildenbrand (Arm)
2026-05-13 13:20 ` David Hildenbrand (Arm)
2026-05-13 16:01 ` Georgi Djakov
2026-05-13 16:07 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f0b2894-ba79-4ef5-8be0-be8f4b5dd3ff@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=djakov@kernel.org \
--cc=georgi.djakov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox