From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFFDEC3DA66 for ; Fri, 25 Aug 2023 12:58:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA58E900017; Fri, 25 Aug 2023 08:58:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E54DB8E0015; Fri, 25 Aug 2023 08:58:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1D1A900017; Fri, 25 Aug 2023 08:58:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C337A8E0015 for ; Fri, 25 Aug 2023 08:58:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 84AFB1C994E for ; Fri, 25 Aug 2023 12:58:10 +0000 (UTC) X-FDA: 81162629940.17.8087FB2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 4B77C4001D for ; Fri, 25 Aug 2023 12:58:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U9iFhhjM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692968288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GBNFTvdriLPppzHDS0vd7lqIVYVAXCvQTC0sUYC9WhM=; b=wpMOcCNi+g+6/xRqLiWpMQ1r1DypQ6bQUs+y7vOrDPe2nLoaVWTeOo8UCLUX7pfmzqHfss tjHn9XTY3rTZ3t2YsoG1uInnPyUphJiED0zvaLyTeIxlfHD4oOgfh+zZCzeM7RrQi8mSFL qBEPfM89QWyxcCHKqTLEh/Zfu8c4pNM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U9iFhhjM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692968288; a=rsa-sha256; cv=none; b=ENpUuUaqWT9gDOnYIemSmV/zsVzIlP2PmCr/T9GAYkRiTTHsAeAfhaQlbr/GKR0i9xBkSI lDRDGrtBkNzmke8M81TcGFICgDSH20g+qvK7zXaj3UsJOdUZM1cNooijw3hIwLyMmKki3f zBIPb+DzdizZRnRLZEBOM+oKoYZXI1Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692968287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GBNFTvdriLPppzHDS0vd7lqIVYVAXCvQTC0sUYC9WhM=; b=U9iFhhjMFdhEHS/thnPQUJxR9eIsRCT4g+HhgseWHwbACaovOkoCNpv/EoYpiXumeKNYtu UzREJgsYSBv9jJPzk7AA1HeilTXUHARWgbuAxS40opkW1TjM6Gn+m5WLiJlKrKhE/DZZUc D/c6/HxYYnCucejrY83WpTc2UZxR0AY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-cEgRzppbP-e7NZrrLhL4Mg-1; Fri, 25 Aug 2023 08:58:06 -0400 X-MC-Unique: cEgRzppbP-e7NZrrLhL4Mg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fefc7845a2so7344225e9.1 for ; Fri, 25 Aug 2023 05:58:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692968285; x=1693573085; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GBNFTvdriLPppzHDS0vd7lqIVYVAXCvQTC0sUYC9WhM=; b=ALpIE8aF12mzVZ4gEGu2argeSdKHjkGIBXOCGVAIKu4X+XTGBh6zgHvFjuuIfHzLL+ myDn300liOGmEYWZchl1V2Z8Y6jbIbTqOi9/yVv8LozFhhBhPMSKz5Xz+gT9tfZb/oot 1pipV3wltouUi/QsIHguIUlIMeR2TD+nUogqJm7NgGOfzTmyocVkpt2DFwn3ueN9JXOm eS46Ps/ytpqgYpww4eIF9g8rLzcl9QngmKeyRJA+vz+fegShLixnyvbE86kWB+XgiZTk MhF1oRYPIAYcd2CL797gfD2xkTj7/f4XDfScpoIj6oE0Q+KJLTXdmAwngbDYcPmGZdR5 E4NA== X-Gm-Message-State: AOJu0YweW11qCuFaxuX8o88U6Y31AtC702VLaqRtGwECl1AAJII7eLzN eHnb/HSrz/jOstnDnQ/2O+8ZW38lKUVsUuyYpOwNR06rMs2xPMaxExhPQ4R2XXDJi5uWUclOWV4 53iANsdBkrAybiwX9JRg= X-Received: by 2002:a05:600c:3799:b0:3f5:878:c0c2 with SMTP id o25-20020a05600c379900b003f50878c0c2mr14208406wmr.3.1692968285179; Fri, 25 Aug 2023 05:58:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIWzFG8Vg+V8chVstmx3m6+6mqzbpA3c0OYtwpWWOzh8XQfnAz6aBjRxNoEBn9X7lmQTXB9A== X-Received: by 2002:a05:600c:3799:b0:3f5:878:c0c2 with SMTP id o25-20020a05600c379900b003f50878c0c2mr14208394wmr.3.1692968284772; Fri, 25 Aug 2023 05:58:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9200:ce93:b5e6:8aa9:65d4? (p200300cbc70e9200ce93b5e68aa965d4.dip0.t-ipconnect.de. [2003:cb:c70e:9200:ce93:b5e6:8aa9:65d4]) by smtp.gmail.com with ESMTPSA id a16-20020a5d5090000000b0031432f1528csm2175306wrt.45.2023.08.25.05.58.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 05:58:04 -0700 (PDT) Message-ID: <9f967665-2cbd-f80b-404e-ac741eab1ced@redhat.com> Date: Fri, 25 Aug 2023 14:58:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [EXTERNAL] Re: [PATCH v3] mm/thp: fix "mm: thp: kill __transhuge_page_enabled()" To: Matthew Wilcox Cc: Saurabh Singh Sengar , Zach O'Keefe , "linux-mm@kvack.org" , Yang Shi , "linux-kernel@vger.kernel.org" , Greg KH , Saurabh Sengar References: <20230821234844.699818-1-zokeefe@google.com> <37c2b525-5c2c-d400-552c-9ccb91f4d7bf@redhat.com> <3e08d48b-7b70-cc7f-0ec1-12ad9b1a33db@redhat.com> <3408ff54-f353-0334-0d66-c808389d2f01@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4B77C4001D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: g6rtoxcs8th83xst3dw6j8wcwstawyer X-HE-Tag: 1692968288-40882 X-HE-Meta: U2FsdGVkX1/GFdWoOCXsmavNS2GMdahgd2m8TnNOR1B8LGiQpH+YbcktVC2JRHkjU2OiHZF5cOo6JbfwujhH4gJnfGfiNFmG3sH/F12/+2s5k4l4Hq86HjunAtnZKf39Je7Li4WCVr50LR6ndmX73bsbBbWfgLDF6JBolMNPB1qotVIOaQG0xahtJeZwRigPKg408Ienwl+EUZADb12PKyrHxUqxYaSeSHhYEa84jRc2a+wVoUam0cjbGUCRjw/J0LNbAzzTVgz45sDi0IuUQRTL6zE2Qkelz8NjO86v+Kp/Hf96n+QQwV+Do596vCuDwYyPEHg9/kXfxXrH0HIB25Mcl/QkmCF3a2jRjVxRMcq+1mJDA//jHIjdBgGBa2hDLeGc4G9chnICq6z+zYGjsF4rjjjcfH9+mvjVnEyHcNbl0L0H3jqqMaelrRzVP+Q3Eth2WdlNkhpr94QrsXF3GhJKi8KaKJvv860Fx25FtpAH3DWxnGp3g93qBiMm1tSEaLfe+Wq3SnocpkdghH63W9flFevyKZjYjBXrm7untqP3jnMfzp9SR9u1WP7Bgkltc/Zq7BnUAlOdxeElOjvN1e9oX6ItVlwFLJa7JkZReq332cYAiW87mq4yjwlNGhzDpEhDEtj/IsJGVQoMHmX/XIJzFI5UAQE6BgBKAarKzXx4wsV+WeEqASKUiOD+RcW1f6cCBn0WahvV2Mqx8b2Z7ETaEW26bINJRdMv2i83j12VJTarXy1nAg+pAsgfkuINC3ohKpATqKjtNZu4fliOOLoZtSHp8vsH952bsBUlAbCCTKxAi+lrkbHmZvExeLJlCSIgIgNWUJrZa8G98nsBuptT9Hb/+609ElD6wBuTQkTihAgx/5CEK59UfsKOZtbGXDtS4uQnNVYxS0AbuC7QIle3dj5baKaAAhZEtIilXTolUmB6pOOfv1d+Sp8IZpLykpXEhj+BTrVsNikoZYN F+QLPJkD hzZilWZdcIrRlV2Hy+qLmUpYQDzsOyJQzuppNhZm3KCotzNaEw1Da76qIzyztShF7rTfIOLuOlp6jNM+pEe/FBYnvxd4zTtKZN3/V4ZmVMDNZNe3rG3dGJAQynHELIWUa2eckCum930LY+lrZ1yKKosfxDcKDW1S/BIy12zy8rhEAts6u+dBJncV+9AgRRDwI835D1JSSXJSL+8VLw2ARUSFgps/rTIv6DCYiSSxpPOxys1Elvo5EZWep2GW6aPZ1IdVw+WFWV8n12vLbGtKIlK75dPld+57L062Tmt/EFgG4wEn+fS0a6KJ8i8OXGalWnMDZUQRtBX9YotLYhKNfr+DvbPeOUuEHc5R0pEc6S7a+tKdmZozMK/BK73K81GWcLbcEl//hjecnUdV+hDFwbvbFJLN/53epRR3x0FEdL7nbKISdh3IQfeRFu4VqCbkikQWHTTXtNSZnuzE4AFQNRDsyJBROLEgBz8N3RnhdWe8P+DsiByL86ufNlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.08.23 14:49, Matthew Wilcox wrote: > On Fri, Aug 25, 2023 at 09:59:23AM +0200, David Hildenbrand wrote: >> Especially, we do have bigger ->huge_fault changes coming up: >> >> https://lkml.kernel.org/r/20230818202335.2739663-1-willy@infradead.org >> >> If the driver is not in the tree, people don't care. >> >> You really should try upstreaming that driver. >> >> >> So this patch here adds complexity (which I don't like) in order to keep an >> OOT driver working -- possibly for a short time. I'm tempted to say "please >> fix your driver to not use huge faults in that scenario, it is no longer >> supported". >> >> But I'm just about to vanish for 1.5 week into vacation :) >> >> @Willy, what are your thoughts? > > Fundamentally there was a bad assumption with the original patch -- > it assumed that the only reason to support ->huge_fault was for DAX, > and that's not true. It's just that the only drivers in-tree which > support ->huge_fault do so in order to support DAX. Okay, and we are willing to continue supporting that then and it's nothing we want to stop OOT drivers from doing. Fine with me; we should probably reflect that in the patch description. > > Keeping a driver out of tree is always a risky and costly proposition. > It will continue to be broken by core kernel changes, particularly > if/when it does unusual things. > Yes. > I think the complexity is entirely on us. I think there's a simpler way > to handle the problem, but I'd start by turning all of this "admin and > app get to control when THP are used" nonsense into no-ops. Well, simpler, yes, but also more controversial :) -- Cheers, David / dhildenb