Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Foxie Flakey <foxieflakey@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Mike Rapoport <rppt@kernel.org>,  Peter Xu <peterx@redhat.com>,
	Suren Baghdasaryan <surenb@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] userfaultfd: reset err to be 0 when move_pages_ptes succeeded
Date: Tue, 18 Aug 2026 08:54:19 +0700 (WIB)	[thread overview]
Message-ID: <9fb6acbc-19cf-eef5-b877-3bf798767ffa@gmail.com> (raw)
In-Reply-To: <79cbfe54-41f2-9041-89f3-a96e9fb80066@gmail.com>

Not sure where I put text that is not the patch description and not in
changes. I put this on seperate mail reply.

On Tue, 18 Aug 2026, Foxie Flakey wrote:

> During move_pages() operation, when move_pages_ptes() returns EAGAIN,
> the error code is not cleared even after we processed it. This leads
> to a successful retry but then the same pages are retried again due to
> the stale error code. This time move fails because pages are already
> moved, loop is terminated and move_pages() reports a failure.
> Clear the error code once we processes EAGAIN.
>
> Fixes: 50944692052b ("userfaultfd: opportunistic TLB-flush batching for present pages in MOVE")
> Assisted-by: ChatGPT:GPT-5.6-Luna
> Signed-off-by: Foxie Flakey <foxieflakey@gmail.com>

I'll delay figuring what to do with Signed-off-by, I'd rather keep Foxie
Flakey because that what is my "known identity" on internet at various
places like GitHub, Alpine's GitLab and now here in Linux kernel
development. Would be nice if I can keep Foxie Flakey, like again policy is
policy not a suggestion if Foxie Flakey is not allowed.

> ---
> Changes in v2:
> - Updated on description to be easier to understood
> - Reset err before retrying, instead of fixing right at the move_pages_ptes
>   branch.
> - Added Assisted-by, received an answer few days ago from linux-newbies IRC
>   that even I just used AI/LLM as "fast path" of git bisect. I still need
>   to add it following
>   https://docs.kernel.org/process/coding-assistants.html doc.

Would be nice to not have to add this Assisted-by. Mainly because I just
used ChatGPT as "fast path" of git bisect to avoid needing recompiling
kernels during bisect if ChatGPT found result first before I finished git
bisect. I feel like my effort trying to understand how to mail, write
patches is undermined, but policy is policy so I don't mind if it has to
stay.

> ---
>  mm/userfaultfd.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
> index c3adedaaf7d5..ec5d511bd179 100644
> --- a/mm/userfaultfd.c
> +++ b/mm/userfaultfd.c
> @@ -2085,8 +2085,10 @@ static ssize_t move_pages(struct userfaultfd_ctx *ctx, unsigned long dst_start,
>  		}
>
>  		if (err) {
> -			if (err == -EAGAIN)
> +			if (err == -EAGAIN) {
> +				err = 0;
>  				continue;
> +			}
>  			break;
>  		}
>
>
> base-commit: 62cc90241548d5570ee68e01aaba6506964e9811
> --
> 2.55.0
>
>


      reply	other threads:[~2026-08-18  1:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  1:44 [PATCH v2] userfaultfd: reset err to be 0 when move_pages_ptes succeeded Foxie Flakey
2026-08-18  1:54 ` Foxie Flakey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fb6acbc-19cf-eef5-b877-3bf798767ffa@gmail.com \
    --to=foxieflakey@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox