From: tarunsahu@google.com
To: Mike Rapoport <rppt@kernel.org>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
Alexander Graf <graf@amazon.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, Mike Rapoport <rppt@kernel.org>,
Breno Leitao <leitao@debian.org>
Subject: Re: [PATCH v4 2/2] luo: Update serialized data to use KHOSER_PTR
Date: Tue, 23 Jun 2026 10:53:45 +0000 [thread overview]
Message-ID: <9huzse6dle86.fsf@tarunix.c.googlers.com> (raw)
In-Reply-To: <ajpbHkuWiGQrUec8@kernel.org>
Mike Rapoport <rppt@kernel.org> writes:
> On Tue, Jun 23, 2026 at 09:56:40AM +0000, tarunsahu@google.com wrote:
>> Mike Rapoport <rppt@kernel.org> writes:
>>
>> > On Mon, 22 Jun 2026 22:57:36 +0000, Tarun Sahu <tarunsahu@google.com> wrote:
>> >> Convert raw serialized_data to KHO serializeable pointer (KHOSER_PTR).
>> >> This series also takes care of resolving the bug with memfd of using
>> >> phys_to_virt before checking the args->serialized_data value.
>> >
>> > For easier backporting the memfd fix should be a standalone commit that
>> > comes first in the series.
>> >
>> > Other than that
>>
>> It will break compilation for individual patch. For example, memfd_luo
>> changes are hard coded dependent on the args->serialized_data
>> conversion to KHOSER_PTR?
>>
>> Maybe I did not understand, Could you please explain what you mean?
>
> Sorry I wasn't clear.
> If people think it's important to have the memfd_luo fix in 7.1, the fix
> should be the first patch in the series and shouldn't use KHOSER pointers.
I dont think, this is critical issue. But it will be a good practice. I
sent v5 with these changes.
Thanks for the review!
~Tarun
>
>> >
>> > Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
>> >
>> > --
>> > Sincerely yours,
>> > Mike.
>
> --
> Sincerely yours,
> Mike.
prev parent reply other threads:[~2026-06-23 10:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 22:57 [PATCH v4 0/2] luo: convert serialized ptr to KHOSER_PTR Tarun Sahu
2026-06-22 22:57 ` [PATCH v4 1/2] kho: add KHOSER_COPY_TYPE(UN)SAFE for phys copy Tarun Sahu
2026-06-23 9:40 ` Mike Rapoport
2026-06-23 9:57 ` tarunsahu
2026-06-22 22:57 ` [PATCH v4 2/2] luo: Update serialized data to use KHOSER_PTR Tarun Sahu
2026-06-23 9:40 ` Mike Rapoport
2026-06-23 9:56 ` tarunsahu
2026-06-23 10:08 ` Mike Rapoport
2026-06-23 10:53 ` tarunsahu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9huzse6dle86.fsf@tarunix.c.googlers.com \
--to=tarunsahu@google.com \
--cc=akpm@linux-foundation.org \
--cc=graf@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox