Re: [PATCH 1/7] x86: mm: clean up tlb flushing code

[Eric Boxer <boxerspam1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

Eric Boxer liked your message with Boxer. On March 6, 2014 at 6:51:28 PM CST, Davidlohr Bueso  wrote:On Thu, 2014-03-06 at 16:16 -0800, Davidlohr Bueso wrote:> On Wed, 2014-03-05 at 16:45 -0800, Dave Hansen wrote:> > From: Dave Hansen > > > > The> > > > if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) > > > > line of code is not exactly the easiest to audit, especially when> > it ends up at two different indentation levels. This eliminates> > one of the the copy-n-paste versions. It also gives us a unified> > exit point for each path through this function. We need this in> > a minute for our tracepoint.> > > > > > Signed-off-by: Dave Hansen > > ---> > > > b/arch/x86/mm/tlb.c | 23 +++++++++++------------> > 1 file changed, 11 insertions(+), 12 deletions(-)> > > > diff -puN arch/x86/mm/tlb.c~simplify-tlb-code arch/x86/mm/tlb.c> > --- a/arch/x86/mm/tlb.c~simplify-tlb-code 2014-03-05 16:10:09.607047728 -0800> > +++ b/arch/x86/mm/tlb.c 2014-03-05 16:10:09.610047866 -0800> > @@ -161,23 +161,24 @@ void flush_tlb_current_task(void)> > void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,> > unsigned long end, unsigned long vmflag)> > {> > + int need_flush_others_all = 1;> > nit: this can be bool.never mind, you get rid of it later.--To unsubscribe from this list: send the line "unsubscribe linux-kernel" inthe body of a message to majordomo@vger.kernel.orgMore majordomo info at http://vger.kernel.org/majordomo-info.htmlPlease read the FAQ at http://www.tux.org/lkml/     

[-- Attachment #2: Type: text/html, Size: 2232 bytes --]