From: Muchun Song <muchun.song@linux.dev>
To: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
"Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
Vishal Moola <vishal.moola@gmail.com>,
Peter Xu <peterx@redhat.com>, Ryan Roberts <ryan.roberts@arm.com>,
christophe.leroy2@cs-soprasteria.com,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 08/14] mm: copy_pte_range() use pte_offset_map_rw_nolock()
Date: Thu, 29 Aug 2024 16:13:44 +0800 [thread overview]
Message-ID: <A619C874-E6B9-4D07-82B9-ABBCDB39DFC2@linux.dev> (raw)
In-Reply-To: <71100c3867c4cf6f5f429ce9f2db8432066d0e99.1724310149.git.zhengqi.arch@bytedance.com>
> On Aug 22, 2024, at 15:13, Qi Zheng <zhengqi.arch@bytedance.com> wrote:
>
> In copy_pte_range(), we may modify the src_pte entry after holding the
> src_ptl, so convert it to using pte_offset_map_rw_nolock(). But since we
> already hold the write lock of mmap_lock, there is no need to get pmdval
> to do pmd_same() check, just pass a dummy variable to it.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Reviewed-by: Muchun Song <muchun.song@linux.dev>
next prev parent reply other threads:[~2024-08-29 8:14 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 7:13 [PATCH v2 00/14] introduce pte_offset_map_{ro|rw}_nolock() Qi Zheng
2024-08-22 7:13 ` [PATCH v2 01/14] mm: pgtable: " Qi Zheng
2024-08-26 3:45 ` [PATCH v2 01/14 update] " Qi Zheng
2024-08-26 15:21 ` [PATCH v2 01/14] " David Hildenbrand
2024-08-27 4:33 ` Qi Zheng
2024-08-28 10:48 ` David Hildenbrand
2024-08-29 3:27 ` Qi Zheng
2024-08-29 10:59 ` Qi Zheng
2024-08-29 15:31 ` David Hildenbrand
2024-08-30 6:37 ` Qi Zheng
2024-08-28 9:48 ` Muchun Song
2024-08-22 7:13 ` [PATCH v2 02/14] arm: adjust_pte() use pte_offset_map_rw_nolock() Qi Zheng
2024-08-26 15:26 ` David Hildenbrand
2024-08-29 3:39 ` Muchun Song
2024-08-22 7:13 ` [PATCH v2 03/14] powerpc: assert_pte_locked() use pte_offset_map_ro_nolock() Qi Zheng
2024-08-26 15:28 ` David Hildenbrand
2024-08-29 7:21 ` Muchun Song
2024-08-22 7:13 ` [PATCH v2 04/14] mm: filemap: filemap_fault_recheck_pte_none() " Qi Zheng
2024-08-26 15:29 ` David Hildenbrand
2024-08-29 7:23 ` Muchun Song
2024-08-22 7:13 ` [PATCH v2 05/14] mm: khugepaged: __collapse_huge_page_swapin() " Qi Zheng
2024-08-26 15:33 ` David Hildenbrand
2024-08-29 7:25 ` Muchun Song
2024-08-22 7:13 ` [PATCH v2 06/14] mm: handle_pte_fault() use pte_offset_map_rw_nolock() Qi Zheng
2024-08-26 15:36 ` David Hildenbrand
2024-08-27 4:53 ` Qi Zheng
2024-08-29 7:30 ` Muchun Song
2024-08-22 7:13 ` [PATCH v2 07/14] mm: khugepaged: collapse_pte_mapped_thp() " Qi Zheng
2024-08-29 8:10 ` Muchun Song
2024-08-30 6:54 ` Qi Zheng
2024-09-05 6:32 ` Muchun Song
2024-09-05 6:41 ` Qi Zheng
2024-09-05 7:18 ` Muchun Song
2024-08-22 7:13 ` [PATCH v2 08/14] mm: copy_pte_range() " Qi Zheng
2024-08-29 8:13 ` Muchun Song [this message]
2024-08-29 15:36 ` David Hildenbrand
2024-08-30 6:42 ` Qi Zheng
2024-08-22 7:13 ` [PATCH v2 09/14] mm: mremap: move_ptes() " Qi Zheng
2024-08-22 7:13 ` [PATCH v2 10/14] mm: page_vma_mapped_walk: map_pte() " Qi Zheng
2024-08-22 7:13 ` [PATCH v2 11/14] mm: userfaultfd: move_pages_pte() " Qi Zheng
2024-08-22 7:13 ` [PATCH v2 12/14] mm: multi-gen LRU: walk_pte_range() " Qi Zheng
2024-08-22 7:13 ` [PATCH v2 13/14] mm: pgtable: remove pte_offset_map_nolock() Qi Zheng
2024-08-22 7:13 ` [PATCH v2 14/14] mm: khugepaged: retract_page_tables() use pte_offset_map_rw_nolock() Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A619C874-E6B9-4D07-82B9-ABBCDB39DFC2@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy2@cs-soprasteria.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=vbabka@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).