From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0751C6FD35 for ; Thu, 29 Aug 2024 08:14:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57FB06B00BC; Thu, 29 Aug 2024 04:14:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 556BB6B00C2; Thu, 29 Aug 2024 04:14:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41FDC6B00C4; Thu, 29 Aug 2024 04:14:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 23E076B00BC for ; Thu, 29 Aug 2024 04:14:29 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 84C941C4262 for ; Thu, 29 Aug 2024 08:14:28 +0000 (UTC) X-FDA: 82504571016.27.5989764 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf05.hostedemail.com (Postfix) with ESMTP id CA5A710000A for ; Thu, 29 Aug 2024 08:14:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MZhnUD3O; spf=pass (imf05.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724919178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C1JpaO0p578z0JlRYTDlBV8oEu2LaEMO2fmkIIoTjZ8=; b=1j2DLzRlK/7UGe/5St87u8MONO3VAhIVysApgehd0XXRWriSb1fnrDCKiEhIG0QsRDNSpM aAFxEi2JMYKsgihaAL2LzQfAyYxlahpewN7MxEdNrgXFmLiiWHDMp+oH9wTwnvBWX3mcS8 IOVkoJHKNdFSe/nZ0exbHKt+TQaa/Ak= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724919178; a=rsa-sha256; cv=none; b=ekhEmvnxdHZLDOtctzgGrCHOgLcgmBGcOv/E454tANDVa8Jo+84yVeI9zbwkQZbJYbqpj8 lhVv/XYdKaKh+vblaLGNZ7M4D6Y1Ko8XzK1MyDx+CJcocdK8Ov11+UspSxPia6Q2+f7oeC lXWolXVtrQIgSnzh57OAElP6WCzLCxU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MZhnUD3O; spf=pass (imf05.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724919265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C1JpaO0p578z0JlRYTDlBV8oEu2LaEMO2fmkIIoTjZ8=; b=MZhnUD3OA6hfnpuCvhcT9WanxHGrxto7GxoZAz+ucJTqn5NEbWKTeExpkW7Z10o7NMM+uw JQ6hiuDtDCC3rIREnHZ1BAwCYMqdyDNy0YQu3Fd5b3vrMXbiqLFyZpJ570SDylBHjZqA/6 JdhGRC8uQe4IxXbqdH48Oj+NaVM+1So= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: [PATCH v2 08/14] mm: copy_pte_range() use pte_offset_map_rw_nolock() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <71100c3867c4cf6f5f429ce9f2db8432066d0e99.1724310149.git.zhengqi.arch@bytedance.com> Date: Thu, 29 Aug 2024 16:13:44 +0800 Cc: David Hildenbrand , Hugh Dickins , Matthew Wilcox , "Vlastimil Babka (SUSE)" , Andrew Morton , Mike Rapoport , Vishal Moola , Peter Xu , Ryan Roberts , christophe.leroy2@cs-soprasteria.com, LKML , Linux Memory Management List , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Message-Id: References: <71100c3867c4cf6f5f429ce9f2db8432066d0e99.1724310149.git.zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CA5A710000A X-Stat-Signature: p43xx6tersyd3e6oi47zccm461e11yx6 X-HE-Tag: 1724919266-35034 X-HE-Meta: U2FsdGVkX1/nhhRAmwNKHaaB+dHcQeCg+Jpw7BTt0/Dkte17fbtHESJ5Tk7DAvCkhVGiM1Bs/5pqElrAuniJcx9xvVbhGIdE1XyWdsIEIVcg6FmicKXUgI457NvEstBi9tc1Ot6F9x9Q6le0PvkHHCLUDa8BPxYkOPu/5lZDsz5RWgA+qs4Omoh5jd3UdG1Vs/kl9+sM4GR2DLnGHXteJ3sPA+v2Fjo+3UmAfEDkXy+M4yVFo7JwROuwJJWUjs9iK3yW1Qu/ZTtA0xcMAmfxbbxJ+CLyZgNeYixXs7PW7oNZv73eV5vTXl3NESAP+KMT5KG7nFiepmQVTi5LCIGk3MsD1giGbkEjPmVedHPCyMaacGYyUDHcM7edvG7Vv4g1ca48xSLjK/5NFC773JzQFDXMS5lxJnFdGxFA6rJLFo8LOUrt9noouhCmqKtKiZAmhDn/QtfDjFy3v1MVTya51oQHE5dkxpB2CWqjSUhT5viS6PdlavFLUjUvG65k9mMnexzwlI291fvOUWED0blwTs/RgaCGUBsLPCl+FTPPp6q54WNw7zGkCya5Uw46AuRta9KswJOyZ6pGXADjSzomUAfxWP+lfxzNSdjSJHKHX4FyhQ1qw6rILtQWMW+QUnRkgWURmuBe5k/jiWepHmWDjuAZFiCVFaqVfHt3ZfCWyLZWlmaCcvXfalEkysVkBybgBYefQK7kgAXMo3ldoKAVYpulDqUEblQMaKZBK7khGCaAey8o9CyuSWeGd+slzE4o1RF02kib2MsKziuLONvprIf2bj1Bf4dJx5mDure+RyV75RFgva1/ANl2kP58TMs4c2VU29s75w6WhRgHATJCRnltSZOIBONqqc/fiyTFwYd51f8iyB9K23aL9gpnlUgV9doipDRb/Yr2MtlG1VkstfepsORrM6nIybP6pMp3OKBnjMIGxyD4Ia/MG1PoPX0QS/6zqJVSJDMjpagfF+O P05J1GcJ lhfABB3p/z7FASTVWB1SUw+vZjPSRPNHNCx3CyUsLs1qausIIH3QdIqkp+8k09Q9o9myCtmaymSDuiHXsYMT4i/4jEekq4+RykFfq01L2F053QpDIncYhqYIWvs80Dr3xLGePnM9N7pgfQqL8Kfc1eZPGgp5EXLugkQQqmEVXRPBTKndNYlNtXuOUmgnT37+BjcMfG5CRMOZuFkclUBrUf1Mj025WHNisK5iriVooxAq5r7bQqI5bjDQAhZqD+9Gi6GOVKTik7hu83LWktMniXmPWk1SHVJQg2PMg0vGBXuJ4lcXtYtMvuSr7Zflb/19PmfGjmtKTOx5uXRAlcZgwfR88EBoWqYqzQTSJ57N5VPB7DwtdbwoHEswhVYJyPJb/PYzkdh442MazdK9pToKj8ApCtXYWygdIGv2s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Aug 22, 2024, at 15:13, Qi Zheng wrote: > > In copy_pte_range(), we may modify the src_pte entry after holding the > src_ptl, so convert it to using pte_offset_map_rw_nolock(). But since we > already hold the write lock of mmap_lock, there is no need to get pmdval > to do pmd_same() check, just pass a dummy variable to it. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song