From: Dave Young <hidave.darkstar@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] Add vzalloc shortcut
Date: Tue, 19 Oct 2010 10:24:44 +0800 [thread overview]
Message-ID: <AANLkTik_yrUkbY+UpA0A9CJcDDXc9kd-MFVhqCNdK_JP@mail.gmail.com> (raw)
In-Reply-To: <20101018191840.89b39aa3.akpm@linux-foundation.org>
On Tue, Oct 19, 2010 at 10:18 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Tue, 19 Oct 2010 09:55:17 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
>
>> On Tue, Oct 19, 2010 at 9:27 AM, Dave Young <hidave.darkstar@gmail.com> wrote:
>> > On Tue, Oct 19, 2010 at 7:46 AM, Andrew Morton
>> >>
>> >> Also, a slightly better implementation would be
>> >>
>> >> static inline void * vmalloc_node_flags(unsigned long size, gfp_t flags)
>> >> {
>> >> return vmalloc_node(size, 1, flags, PAGE_KERNEL, -1,
>> >> builtin_return_address(0));
>> >> }
>>
>> Is this better? might vmalloc_node_flags would be used by other than vmalloc?
>>
>> static inline void * vmalloc_node_flags(unsigned long size, int node,
>> gfp_t flags)
>
> I have no strong opinions, really. If we add more and more arguments
> to vmalloc_node_flags() it ends up looking like vmalloc_node(), so we
> may as well just call vmalloc_node(). Do whatever feels good ;)
Ok, thanks.
Then I would prefer add 'node' argument due to the function name of
vmalloc_node_flags
--
Regards
dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-19 2:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 4:33 [PATCH 1/2] Add vzalloc shortcut Dave Young
2010-10-17 4:50 ` Minchan Kim
2010-10-18 16:36 ` Christoph Lameter
2010-10-18 23:46 ` Andrew Morton
2010-10-19 1:27 ` Dave Young
2010-10-19 1:55 ` Dave Young
2010-10-19 2:18 ` Andrew Morton
2010-10-19 2:24 ` Dave Young [this message]
2010-10-19 13:55 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik_yrUkbY+UpA0A9CJcDDXc9kd-MFVhqCNdK_JP@mail.gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).