From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id E0B346B02A3 for ; Fri, 16 Jul 2010 01:46:30 -0400 (EDT) Received: by qyk12 with SMTP id 12so557604qyk.14 for ; Thu, 15 Jul 2010 22:46:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1278756333-6850-1-git-send-email-lliubbo@gmail.com> <1279058027.936.236.camel@calx> Date: Fri, 16 Jul 2010 13:46:28 +0800 Message-ID: Subject: Re: [PATCH] slob_free:free objects to their own list From: Bob Liu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Pekka Enberg Cc: Matt Mackall , akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, LKML , Mel Gorman List-ID: On Wed, Jul 14, 2010 at 5:07 PM, Pekka Enberg wrot= e: > On Wed, Jul 14, 2010 at 12:53 AM, Matt Mackall wrote: >> On Tue, 2010-07-13 at 20:52 +0300, Pekka Enberg wrote: >>> Hi Bob, >>> >>> [ Please CC me on SLOB patches. You can use the 'scripts/get_maintainer= .pl' >>> =C2=A0 script to figure out automatically who to CC on your patches. ] >>> >>> On Sat, Jul 10, 2010 at 1:05 PM, Bob Liu wrote: >>> > slob has alloced smaller objects from their own list in reduce >>> > overall external fragmentation and increase repeatability, >>> > free to their own list also. >>> > >>> > Signed-off-by: Bob Liu >>> >>> The patch looks sane to me. Matt, does it look OK to you as well? >> >> Yep, this should be a marginal improvement. >> >> Acked-by: Matt Mackall > > Great! Bob, if you could provide the /proc/meminfo numbers for the > patch description, I'd be more than happy to merge this. > Hi, Pekka Sorry for the wrong cc and later reply. This is /proc/meminfo result in my test machine: without this patch: =3D=3D=3D MemTotal: 1030720 kB MemFree: 750012 kB Buffers: 15496 kB Cached: 160396 kB SwapCached: 0 kB Active: 105024 kB Inactive: 145604 kB Active(anon): 74816 kB Inactive(anon): 2180 kB Active(file): 30208 kB Inactive(file): 143424 kB Unevictable: 16 kB .... with this patch: =3D=3D=3D MemTotal: 1030720 kB MemFree: 751908 kB Buffers: 15492 kB Cached: 160280 kB SwapCached: 0 kB Active: 102720 kB Inactive: 146140 kB Active(anon): 73168 kB Inactive(anon): 2180 kB Active(file): 29552 kB Inactive(file): 143960 kB Unevictable: 16 kB ... The result show only very small improverment! And when i tested it on a embeded system with 64MB, I found this path is never called while kernel booting. Thanks for the kindly review. --=20 Regards, --Bob -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org