From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Christoph Lameter <cl@linux.com>
Cc: Greg Thelen <gthelen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Mel Gorman <mel@csn.ul.ie>,
kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp,
balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: Consider the entire user address space during node migration
Date: Sat, 15 May 2010 23:31:16 +0900 [thread overview]
Message-ID: <AANLkTil4zgqBtBAp--P8VdynpbohxVosQ-qFiQQ_c5Bb@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1005141626250.20193@router.home>
Hi
Mysteriously, I haven't receive original post.
So now I'm guessing you acked following patch.
http://lkml.org/lkml/2010/5/14/393
but I don't think it is correct.
> - check_range(mm, mm->mmap->vm_start, TASK_SIZE, &nmask,
> + check_range(mm, mm->mmap->vm_start, TASK_SIZE_MAX, &nmask,
> flags | MPOL_MF_DISCONTIG_OK, &pagelist);
Because TASK_SIZE_MAX is defined on x86 only. Why can we ignore other platform?
Please put following line anywhere.
#define TASK_SIZE_MAX TASK_SIZE
But this patch is conceptually good. if it fixes the bug. I'll ack gladly.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-15 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 20:46 [PATCH] mm: Consider the entire user address space during node migration Greg Thelen
2010-05-14 21:26 ` Christoph Lameter
2010-05-15 14:31 ` KOSAKI Motohiro [this message]
2010-05-15 22:35 ` [PATCH v2] " Greg Thelen
2010-05-16 1:14 ` Christoph Lameter
2010-05-17 0:00 ` KOSAKI Motohiro
2010-05-15 22:44 ` [PATCH] " Greg Thelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTil4zgqBtBAp--P8VdynpbohxVosQ-qFiQQ_c5Bb@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=cl@linux.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).