From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 5816860071F for ; Tue, 29 Jun 2010 10:27:07 -0400 (EDT) Received: by iwn35 with SMTP id 35so187383iwn.14 for ; Tue, 29 Jun 2010 07:27:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1277811288-5195-2-git-send-email-mel@csn.ul.ie> References: <1277811288-5195-1-git-send-email-mel@csn.ul.ie> <1277811288-5195-2-git-send-email-mel@csn.ul.ie> Date: Tue, 29 Jun 2010 23:27:05 +0900 Message-ID: Subject: Re: [PATCH 01/14] vmscan: Fix mapping use after free From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , Andrea Arcangeli List-ID: On Tue, Jun 29, 2010 at 8:34 PM, Mel Gorman wrote: > From: Nick Piggin > > Use lock_page_nosync in handle_write_error as after writepage we have no > reference to the mapping when taking the page lock. > > Signed-off-by: Nick Piggin > Signed-off-by: Mel Gorman Trivial. Please modify description of the function if you have a next turn. "run sleeping lock_page()" -> "run sleeping lock_page_nosync" -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org