From: Minchan Kim <minchan.kim@gmail.com>
To: Eric B Munson <emunson@mgebm.net>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, mel@csn.ul.ie,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Rename struct task variables from p to tsk
Date: Thu, 13 Jan 2011 08:14:12 +0900 [thread overview]
Message-ID: <AANLkTimFGNxJzNMAJg-mWN-VOxonQ+odE9WBEEEsaw5O@mail.gmail.com> (raw)
In-Reply-To: <1294845571-11529-1-git-send-email-emunson@mgebm.net>
On Thu, Jan 13, 2011 at 12:19 AM, Eric B Munson <emunson@mgebm.net> wrote:
> p is not a meaningful identifier, this patch replaces all instances
> in page_alloc.c of p when used as a struct task with the more useful
> tsk.
>
Yesterday, Andrew raise an eyebrow about that.
His simple lookup found below.
--
On Tue, 11 Jan 2011 13:03:22 -0800 (PST)
Hugh Dickins <hughd@google.com> wrote:
> On Tue, 11 Jan 2011, Andrew Morton wrote:
< snip >
> > Oh, and since when did we use `p' to identify task_structs?
>
> Tsk, tsk: we've been using `p' for task_structs for years and years!
Only bad people do that. "p". Really?
z:/usr/src/linux-2.6.37> grep -r " \*p;" . | wc -l
2329
z:/usr/src/linux-2.6.37> grep -r "task_struct \*p" . | wc -l
824
bah.
--
How about cleaning up everything in this chance?
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-12 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 15:19 [PATCH] Rename struct task variables from p to tsk Eric B Munson
2011-01-12 18:05 ` Christoph Lameter
2011-01-12 20:16 ` Eric B Munson
2011-01-12 20:23 ` Christoph Lameter
2011-01-12 20:16 ` David Rientjes
2011-01-12 23:14 ` Minchan Kim [this message]
2011-01-13 3:23 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimFGNxJzNMAJg-mWN-VOxonQ+odE9WBEEEsaw5O@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=emunson@mgebm.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).