From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Sam Creasey <sammy@sammy.net>,
Andrew Morton <akpm@linux-foundation.org>,
Linux/m68k <linux-m68k@vger.kernel.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH/RFC] m68k/sun3: Kill pte_unmap() warnings
Date: Sun, 5 Dec 2010 12:11:14 +0100 [thread overview]
Message-ID: <AANLkTimfSh8QYLr1bvxcKUwtRLRLLM1J3CCn8uYmKY7v@mail.gmail.com> (raw)
In-Reply-To: <m2wroynj4t.fsf@igel.home>
On Sun, Oct 31, 2010 at 22:32, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>
>> Which one is preferable?
>>
>> -------------------------------------------------------------------------------
>> Since commit 31c911329e048b715a1dfeaaf617be9430fd7f4e ("mm: check the argument
>> of kunmap on architectures without highmem"), we get lots of warnings like
>>
>> arch/m68k/kernel/sys_m68k.c:508: warning: passing argument 1 of ‘kunmap’ from incompatible pointer type
>>
>> As m68k doesn't support highmem anyway, open code the calls to kmap() and
>> kunmap() (the latter is a no-op) to kill the warnings.
>
> I prefer this one, it matches all architectures without CONFIG_HIGHPTE.
Thx, applied for 2.6.38, with updated commit message.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-12-05 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 20:38 [PATCH/RFC] m68k/sun3: Kill pte_unmap() warnings Geert Uytterhoeven
2010-10-31 21:32 ` Andreas Schwab
2010-12-05 11:11 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimfSh8QYLr1bvxcKUwtRLRLLM1J3CCn8uYmKY7v@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sammy@sammy.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).