From: Minchan Kim <minchan.kim@gmail.com>
To: Hugh Dickins <hughd@google.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: add replace_page_cache_page() function
Date: Fri, 17 Dec 2010 13:37:39 +0900 [thread overview]
Message-ID: <AANLkTin-JUMNvoTubuVawsJLi89rG84K6EG3EBuc5gsK@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1012161804280.4484@tigran.mtv.corp.google.com>
On Fri, Dec 17, 2010 at 11:10 AM, Hugh Dickins <hughd@google.com> wrote:
> On Fri, 17 Dec 2010, Minchan Kim wrote:
>> On Fri, Dec 17, 2010 at 10:21 AM, Hugh Dickins <hughd@google.com> wrote:
>> >
>> > I disagree with you there: I like the way Miklos made it symmetric,
>> > I like the way delete_from_swap_cache drops the swap cache reference,
>> > I dislike the way remove_from_page_cache does not - I did once try to
>> > change that, but did a bad job, messed up reiserfs or reiser4 I forget
>> > which, retreated in shame.
>>
>> I agree symmetric is good. I just said current fact which is that
>> remove_from_page_cache doesn't release ref.
>> So I thought we have to match current semantic to protect confusing.
>> Okay. I will not oppose current semantics.
>> Instead of it, please add it (ex, caller should hold the page
>> reference) in function description.
>>
>> I am happy to hear that you tried it.
>> Although it is hard, I think it's very valuable thing.
>> Could you give me hint to googling your effort and why it is failed?
>
> http://lkml.org/lkml/2004/10/24/140
Thanks.
Now we have only 3 callers of remove_from_page_cache in mmtom.
1. truncate_huge_page
2. shmem_writepage
3. truncate_complete_page
4. fuse_try_move_page
It seems all of caller hold the page reference so It's ok to change
the semantic of remove_from_page_cache.
Okay. I will do that.
>
> Hugh
>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-17 4:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 15:49 [PATCH] mm: add replace_page_cache_page() function Miklos Szeredi
2010-12-15 16:49 ` Rik van Riel
2010-12-15 23:22 ` Minchan Kim
2010-12-16 11:59 ` Miklos Szeredi
2010-12-16 22:04 ` Minchan Kim
2010-12-17 1:21 ` Hugh Dickins
2010-12-17 1:40 ` Minchan Kim
2010-12-17 2:10 ` Hugh Dickins
2010-12-17 4:37 ` Minchan Kim [this message]
2010-12-17 15:53 ` Miklos Szeredi
2010-12-16 1:07 ` KAMEZAWA Hiroyuki
2010-12-16 12:05 ` Miklos Szeredi
2010-12-17 0:01 ` KAMEZAWA Hiroyuki
2010-12-17 15:51 ` Miklos Szeredi
2010-12-19 23:54 ` KAMEZAWA Hiroyuki
-- strict thread matches above, loose matches on Subject: below --
2011-01-07 18:22 Miklos Szeredi
2011-01-11 2:29 ` KAMEZAWA Hiroyuki
2011-01-11 3:53 ` Daisuke Nishimura
2011-01-11 9:38 ` Miklos Szeredi
2011-01-11 5:41 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin-JUMNvoTubuVawsJLi89rG84K6EG3EBuc5gsK@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).