[PATCH] mm: Remove two memset calls in mm/memcontrol.c by using the zalloc variants of alloc functions

[PATCH] mm: Remove two memset calls in mm/memcontrol.c by using the zalloc variants of alloc functions

[Jesper Juhl]

We can avoid two calls to memset() in mm/memcontrol.c by using 
kzalloc_node(), kzalloc & vzalloc().

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 memcontrol.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 00bb8a6..890df27 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4176,12 +4176,11 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)
 	 */
 	if (!node_state(node, N_NORMAL_MEMORY))
 		tmp = -1;
-	pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, tmp);
+	pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, tmp);
 	if (!pn)
 		return 1;
 
 	mem->info.nodeinfo[node] = pn;
-	memset(pn, 0, sizeof(*pn));
 
 	for (zone = 0; zone < MAX_NR_ZONES; zone++) {
 		mz = &pn->zoneinfo[zone];
@@ -4206,14 +4205,13 @@ static struct mem_cgroup *mem_cgroup_alloc(void)
 
 	/* Can be very big if MAX_NUMNODES is very big */
 	if (size < PAGE_SIZE)
-		mem = kmalloc(size, GFP_KERNEL);
+		mem = kzalloc(size, GFP_KERNEL);
 	else
-		mem = vmalloc(size);
+		mem = vzalloc(size);
 
 	if (!mem)
 		return NULL;
 
-	memset(mem, 0, size);
 	mem->stat = alloc_percpu(struct mem_cgroup_stat_cpu);
 	if (!mem->stat)
 		goto out_free;



-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: Remove two memset calls in mm/memcontrol.c by using the zalloc variants of alloc functions

[Minchan Kim]

On Thu, Jan 13, 2011 at 5:39 AM, Jesper Juhl <jj@chaosbits.net> wrote:
> We can avoid two calls to memset() in mm/memcontrol.c by using
> kzalloc_node(), kzalloc & vzalloc().
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: Remove two memset calls in mm/memcontrol.c by using the zalloc variants of alloc functions

[KAMEZAWA Hiroyuki]

On Wed, 12 Jan 2011 21:39:59 +0100 (CET)
Jesper Juhl <jj@chaosbits.net> wrote:

> We can avoid two calls to memset() in mm/memcontrol.c by using 
> kzalloc_node(), kzalloc & vzalloc().
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Thank you.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: Remove two memset calls in mm/memcontrol.c by using the zalloc variants of alloc functions

[Daisuke Nishimura]

On Wed, 12 Jan 2011 21:39:59 +0100 (CET)
Jesper Juhl <jj@chaosbits.net> wrote:

> We can avoid two calls to memset() in mm/memcontrol.c by using 
> kzalloc_node(), kzalloc & vzalloc().
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Acked-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>