From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7204DC982E6 for ; Mon, 21 Sep 2026 16:21:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75AE06B00C3; Mon, 21 Sep 2026 12:21:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 732826B00C8; Mon, 21 Sep 2026 12:21:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F98E6B00C9; Mon, 21 Sep 2026 12:21:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2F6976B00C3 for ; Mon, 21 Sep 2026 12:21:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B93711A0238 for ; Mon, 21 Sep 2026 16:21:09 +0000 (UTC) X-FDA: 85238283858.22.6D00A3E Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010011.outbound.protection.outlook.com [52.101.193.11]) by imf22.hostedemail.com (Postfix) with ESMTP id EA5C8C000B for ; Mon, 21 Sep 2026 16:21:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=cuPVXxu3; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf22.hostedemail.com: domain of ziy@nvidia.com designates 52.101.193.11 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=cuPVXxu3; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf22.hostedemail.com: domain of ziy@nvidia.com designates 52.101.193.11 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=pass; t=1790007667; b=8lrfPxhVXFr1DtOt3wljjAiPSKwCOMjvx+y32eqBctti9+Bg1TeDBxI/30smztcW1oBeWh QIJrkniNY936DejiLxCp6Uu61yp+Y4mmg7wrq12WM+OwPHpsu+WR2cp7kqjls5u87/dAie t//yarh7fJr/AjogVbMnu+yyC5b5rlo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1790007667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CW1Nu+sRbay3QMOOsHOO6/O8S9MBWMLle7nhYHXtEwE=; b=qbIZh7RTPaH1GOUotQl/bdVvGqLSerEx9oKes1w/VNdjx51HPLAw5HhiQFgZaiP9+ZiCyj DiMssICaPJRaFMoE51abC3+NpZwnQaqsVohVxl8iL6W2o4i1TjxOHWj3cLXPAuM6UKBLoh IiazBSwvFJHnqC9rPtUTJXsmZ/Y48d0= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lWDsfL1VR0dHU+JMOVr9tO7+wm4wCbpuUE7kFRR+8u3VW5s82mPsod+YR/wYkzA3staUxTsfNGJFMljevtqV+AXcq2aUSPpCEpSjiNPPywre7oYRExsB2VI5bMoV30lMNUBTMLPQf/DOSMDq7lSxbgQnOqTdnw281aKKeg+QBMAT1TTl/ZcSys+Aay30r4uvwScGNDpYuJdh/yVLI00B8bqn/4RsBWqd1ciJM0rESJgokMj3RzzsSutjTKlOLjoc+VGTfqu1VAEO0RGGk8g4WbbWfWIAoD5ENvgTYanhrsmwQXio7Ja0cMg3I/ySSLp+Hqneoe8rZYTDxjR1TX9Jvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CW1Nu+sRbay3QMOOsHOO6/O8S9MBWMLle7nhYHXtEwE=; b=dbtX67//kiixJfYVn7PaVn1xVXx0fhQ8jJpQPrHRLSCsk5xuSxb81WfWmxVpv2xkFuamE2gz4X7vWhCp9v/hel/FJnJsviv9jyloqet3rk8RZ/yqTy7BdFWdZ1dhHOmTEgFCleKPyGJ5SIsTwNpKuDV90osVgULJqVbGMbi4ECyj0Ltt5tF72JRWcijyeJ7vopZ1unmYRyBUoc94XMwY0S6OPdpiRxpuCkdZZO9RGlCncM8uZ956uTG2Kaf7swszraxbqeSAIbhJ0ZdaH/hzC7P1csWUWy+miSZ6V/cvTq+9cqbxT/kku+O3fNrvMw1itUYPtaqBpPadOkpJ/mtvzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CW1Nu+sRbay3QMOOsHOO6/O8S9MBWMLle7nhYHXtEwE=; b=cuPVXxu362ja8zOFluW5s00DGm2K3BPA5g/c99UsMMsvNWg9IpBt9MnTUy3Zj906yi8TNdaQgCi1/GL+eDqo7O6T6iP3vw4DvMJLLvwJqRSdkdhlmDOBeKI7R1TVWCd0OcFQ8hjm1hINUuKucxlUoBUKDnYKC+cw+XCoJCJZcDMXfdsv7WJ/hxCOphduPstGDBtYaRvCN7Q/QBS5gg8af4Mgl4nAgBWOo1n3ykMcT8Zm6IowXzdw6vrjeQqqvzI4Mu06HWuxYL70TNloKq6CPMWG1+dYG2lPfmaYYdg2H2tXwaVeC/Gil5U7g8UiscVQ1ykttLKQHDtZW9RPsrQq1Q== Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by CY5PR12MB6347.namprd12.prod.outlook.com (2603:10b6:930:20::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.16; Mon, 21 Sep 2026 16:20:59 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%6]) with mapi id 15.21.0428.015; Mon, 21 Sep 2026 16:20:59 +0000 From: Zi Yan To: Gregory Price Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, brendan.jackman@linux.dev, hannes@cmpxchg.org Subject: Re: [PATCH v2 2/2] mm/page_alloc: refactor build_node_zonelist() out of build_zonelists() Date: Mon, 21 Sep 2026 12:20:57 -0400 X-Mailer: MailMate (3.0r7032) Message-ID: In-Reply-To: References: <20260912030424.2889731-1-gourry@gourry.net> <20260912030424.2889731-3-gourry@gourry.net> Content-Type: text/plain X-MS-Reactions: disallow X-ClientProxiedBy: BN9PR03CA0639.namprd03.prod.outlook.com (2603:10b6:408:13b::14) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|CY5PR12MB6347:EE_ X-MS-Office365-Filtering-Correlation-Id: d2f24889-c1cf-4bbf-95b9-08df17fc5296 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|23010399003|1800799024|10067099003|11063799006|4143699003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: CL7GYDkZPghhCAe0HFZUvoiWhAbgYimR5795C29zZ+NELcs4fcibpulMi+5OAVpEXDXoNxU4oiMut5IQ2dsVZBcn0o9ubsO6aCQ52+h5yBzn5JkzOdmDgDN+COi9WfCpjqA7F7Q9GURrVmg6VttPorhbk2cBOoa09FRiXMlXjn3ooRB3WLGX2MYED0jKeXUbplXsO+vGtW4NZURYmJnyc958Cv3WM9MkIbulT68XN+bUi/dTUVsqoKq+/w7ol1U/6olETRBOY/vGSpsWifrrE8ESSTAMP+/ooQCnuG7/gbrtBRL3h/KvTJLaAnAZuCw3NITKqSYSfbNmrubZYTVorF/CrqI0W0Gw6eT1I9LqQJzMJkFW2alsv6LrVVh/jmanU5r+O0wee6o49/VV1ecbDQ7MKuJ0M/WyDwEzYYa6hJBs9B1fWEInZ25mefYAQySDqUY89PAJnDhlsTWCi+jhH1JoNAlnASEp0W4H2ei6/KhxFfCtn0Ja06e8nNnoCO4e0fNfGMoDZfv6O0cU+z2mTBYuVPKo6wsrJRhjiN4s+UBoQkQW04FKe82dvApbG9PO2jZRp869gzrBboDpi080BRfbwNPHVNx+O2mDev/Ve9aTRmq4T8Gocz3+LWjH1hRBuyP+X1naXeWvz6CuS0uWAk419Pf7lpmbK3qkV+8ucd0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(23010399003)(1800799024)(10067099003)(11063799006)(4143699003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xM8ixYp510aYFJSUEB32MgtS/cbplfzqzKqIH6A2uX+7fA58ceo/6nWh+JPh?= =?us-ascii?Q?rN6N4cgSEAvu0yV4fjmw2jzMn12fIIZjvqIjkeCAKqDnGMP763QrHJMrR9as?= =?us-ascii?Q?jtt6o2cizy35/WXjDdOi/sEBEaf8NdFlqtZdVZe6EcKKO9k5vL2jtl6KDw/d?= =?us-ascii?Q?AZYIrMus1d6oAy9gp6+GbkBDaewFZjCbf/99zDdB0NcZhhbAYlc3BQjv9r5j?= =?us-ascii?Q?SrslI5MmPLnuk8F1kw9asHDsv51ZO7ASNMAaBA0y7MfyP8jRF91W3Rhe3rqg?= =?us-ascii?Q?IjUtB5tQ4sm6rJWSfWNGCCLBXlNPV+zP4L8cXrV0aIMxlBn1UgrrSklRXtYQ?= =?us-ascii?Q?dXhDf/bwQ04xMaeJnjkTFU2RpRSz10dlEk2AZAPf8FUNMI3/W7bySrgUDD18?= =?us-ascii?Q?snsYG1s8gKvLUOoWcnjHTAbzYCwGhlKHpf/K6I1i9oRR5BxgRLnQJEaJtRZQ?= =?us-ascii?Q?ksv3RRR2qmfQGId9J7OPCkHzSmQqRfV1cvKatmCUuDtKDAlffeILpyVbSgnQ?= =?us-ascii?Q?W5O5KA6+RAQOE5DiGQqlbKBQh3jt74pf7HM4Q0EokZNPre/5vVk/W5E/Jx3K?= =?us-ascii?Q?eCt5GKEpRXi7tzQy6CMWIFTkGJaMYCr4+YNYbsMn/OGvE9DFlGutWG+Iyy7m?= =?us-ascii?Q?IJu3/OcDNXOrjiCMSTIe9zjwNZhBhflTDjTDwGiq/Q4HoRiuEZ0SnIRV36x9?= =?us-ascii?Q?kDGQ7As/c2YgR9C0KazP887a2Q97GveWxKYpmpd3a7amiFJQ51Z5MdpTwYeA?= =?us-ascii?Q?X1Pp2tpjFW9DwD//CIsOQ4MGr9f59YfRl1DYQ1t3MRysednWdQkpFPoKt6w6?= =?us-ascii?Q?wWIUd27lWTqek3eP+tj3OXUmUODG9sSJZ5ralRrUEz2tAk0EdrRexzcXyjhp?= =?us-ascii?Q?uOSMP1RGcFqM2R9u7LWDjt+eOlSOK6+9vU4xBUvVslHYPfsl/VcfvqKphxB7?= =?us-ascii?Q?rJZ2Q2XHd0hM24VJqtOietXi+a5rINPYQQ9eWN11fmbFxWf9KhD4gr3RkttA?= =?us-ascii?Q?lnT6Gklub9W9E6Eb1fiCQPrWMGGFUbF97MJWZzhG/iPoqfIdpJlQU2CXgpW8?= =?us-ascii?Q?MNaXBp8kRPqwn6hGfRq4kjlgTg95B+DjCoYzkVYw/6lM2LPG+VyPINI+eE8Q?= =?us-ascii?Q?I2eEsymbN+Uqq1KAP9dGU8yKeLsYggQxXz9+TcoASuvscd8GN5tyGXKK8FmL?= =?us-ascii?Q?FHapqewSSoc7OZkLhS8UEEL4IDly/QOwu9XDkNH7bTcL7kFGHzG5V9h6EBNn?= =?us-ascii?Q?DBxSHlY2E98UufSWWxKPec8W4ZMJICO0kNCW59Ak1yh/2UgB13vAAmWB79zC?= =?us-ascii?Q?Agcnz4XdvPO0Qub2nf5+KqZSbS8eYiWouecPD2bB0Q6KcaUMRh7c62BehJHJ?= =?us-ascii?Q?QUbsmhwNo0qO8TIfIE4sjkncZCHdN+AKM5bJBe1LrnYiu+m0+Z6BU6HJY2xr?= =?us-ascii?Q?stcQcLXeGCuUaMSLDKMd9lPCpoMxGDkBBNEB8VlNet9A578/k6HxbuoWDHdN?= =?us-ascii?Q?py/Zp+G++rC4e0R8PxDr7Zj2lWK5gH1CAroaVMR2DY+bda8cU9rQRCuX5IjD?= =?us-ascii?Q?pL9hKVju75vzosHKskushJ7ZLmoNyXOyOcZdihFLc9U2oaylU7uaYQ3YgnxB?= =?us-ascii?Q?reSpiBF+kj+Zl5YmzeUjkJZJhrB2NketODGWvkcBgubuWLpGnKDN+8aj3WHJ?= =?us-ascii?Q?zxfzZuUTRZSr5p2ArAf5/ItDiXMrZEINAcw4Utj8XoFsqUOSiAbOszxQVj9x?= =?us-ascii?Q?rKKq/vc5tQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2f24889-c1cf-4bbf-95b9-08df17fc5296 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2026 16:20:59.5729 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dPgFlVncbDceZULTcqXckxEA4wejWkmx4g+8Eba/LtVEtx6wkO8b8AVcZb+RXAZ9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6347 X-Rspam-User: X-Rspamd-Queue-Id: EA5C8C000B X-Stat-Signature: nje47jtaddb77qqdirfctenf3wzpmqqm X-Rspamd-Server: rspam01 X-HE-Tag: 1790007666-890677 X-HE-Meta: U2FsdGVkX1+LP9pzBKqqnCy33FDmqIevibBUL8XCMm+JWRoFZ+XBlgZJpg0NIA6zNupCDal/L941aC8WankpMhSiLl9IgOGO9LgPpe/m1N2WDtUym0C/RE5nInLkeJoFH91n+8V8H/BsDyZjERnXeUL/wUWptiWWjLDfNiMhifv0Vqiy2cIHcxgKuhofoxhEibDNOQ1dnD4T4bQ5hoTQYWB7hPWuObmqshU31d3QabcLg79NorMp9+6AHrxdJlyx+ht5CdihS6kw6tWjEKhWOXweOOHSQhEemkmbEkY4Vr6OYG14JFV8nuDBtEr6+iWdNxQ5i5a9TeNmA2MQz7XugGc7U/UrNhEDCOd7C4AwpgfLofKQCoo4xLQ/fX+zvFXCY3KqT2J0KRj2aC6ap1sj0nPj3U3i10s/GPvFwp4v8pi7ZcVVjjfgqlrjbILqu4mrKo34Gwt86TP/J3zhCFXcAVHjKfRljy0nuiY3cr1uGsYuBcMVnDeuJ/KUpR/3Xvsd8PMNiCrlxp9OAgzcaSb14KfE4LWAzUU9wDbolYyUJtgBHXoijmbK1zsmkvQTVxWdeMgh0Bs/806GpnMdXRLigF30pQG3QLb83fplx8bEDRCWKQiVi7SK4WVLVS1UXXq6mq0ZiyT/9rlLsneDPAz+W3/ZpCb9bbuPxRi9bshWQGLHI2h7iwu+vZw26eKiYVIXOLWcPweGaCLeQahrn6wPgR3xG5BRZxNPiZ7juOhxsrMfPpjTPK9zb+JR6iwkFH4VTbi8iePO8iojYDPFqMTw0N79EFlEHjSK3UTpTg9HLwcgN00ERrVtTbSCNlyBUozZUsPG+cfe23qLAOctM//aBuSaRObI1A/KUtR0oOdHzwR2NBtNDfc+Tw/lcksLw0JaHuH2FlpLVn4QYYtzrNwkoIw0sSWaY8sYeTWCPy4Xy0EqkiwpSWLfXV1yrYCoNCUM7mjKmwyR01FqpMH2L9g P3WiArFB EZQJHggEpMcVXL9v6KNV5XPDZy/A+sZX42n+kXH6btKD0EVQ51BVLXaiFsE7+dIzE7j7+Ze7GpAFI/Eqp+HB7UAGh4wMqqV1t27WY59L38Wbk492Yis7ZYaDfYZZ6GPZO9NGMxMg078EhiflpI/9W+FMSBBl8NlAolHFGOXlSQXHvBlTCm1mVvhjWWviUbafqlXzoj6/HET/dFNlAHp9QY/bbIaWSSn0ZL9Sscs4+OGVGT+p/U47ZE4wNnjHOdKXBgX9ixtODmVlEVSlHajvny0y/TH4mb1lElFAROHruFSAgJ9hUdGXEZbcX3Wk1cvFdeIKJQwZ8/IagHLYszbphe0jkUBpt5+5SQ8iZgD+c1fQnEjZQzd3shweaL8UEz5+LmnyR4jarNdoPfjMfQGdObNgyiPA7dFSn2vvYtNOyEe8TuacLHfU3dH6URw== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20 Sep 2026, at 23:33, Gregory Price wrote: > On Sun, Sep 20, 2026 at 10:53:13PM -0400, Zi Yan wrote: >>>> +static void build_node_zonelist(pg_data_t *pgdat, const nodemask_t *candidates, >>>> + int zlidx) >> >> Is build_numa_aware_zonelist() a better name? Since the old comment said >> "NUMA-aware ording of nodes" and the code uses find_next_best_node_in(). >> > > I think that's a vestige of older version having different ordering > options. Now the zonelists are always numa aware (except for > !CONFIG_NUMA, which... duh). Yeah, I am OK with the current name to avoid confusion on !CONFIG_NUMA. > > Anyway numa-aware is implied by "node" in the name. > > But I don't have strong feelings about the name either way. Best Regards, Yan, Zi