linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ying Han <yinghan@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH V3 1/2] count the soft_limit reclaim in global background reclaim
Date: Tue, 29 Mar 2011 14:56:30 -0700	[thread overview]
Message-ID: <BANLkTi=NSsHk9aZJYj2rPGoOvKvVif3aEg@mail.gmail.com> (raw)
In-Reply-To: <20110329145237.b5bb7fbf.akpm@linux-foundation.org>

On Tue, Mar 29, 2011 at 2:52 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Mon, 28 Mar 2011 22:56:25 -0700
> Ying Han <yinghan@google.com> wrote:
>
>> @@ -1442,6 +1443,7 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem,
>>       bool shrink = reclaim_options & MEM_CGROUP_RECLAIM_SHRINK;
>>       bool check_soft = reclaim_options & MEM_CGROUP_RECLAIM_SOFT;
>
> This function rather abuses the concept of `bool'.

hmm. then maybe a separate patch to fix that :)

thanks

--Ying
>
>
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-03-29 21:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29  5:56 [PATCH V3 0/2] Reduce reclaim from per-zone LRU in global kswapd Ying Han
2011-03-29  5:56 ` [PATCH V3 1/2] count the soft_limit reclaim in global background reclaim Ying Han
2011-03-29  6:55   ` Daisuke Nishimura
2011-03-29 21:52   ` Andrew Morton
2011-03-29 21:56     ` Ying Han [this message]
2011-03-29  5:56 ` [PATCH V3 2/2] add stats to monitor soft_limit reclaim Ying Han
2011-03-29  7:03   ` Daisuke Nishimura
2011-03-29  7:12   ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=NSsHk9aZJYj2rPGoOvKvVif3aEg@mail.gmail.com' \
    --to=yinghan@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).