From: "Michał Nazarewicz" <mnazarewicz@gmail.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] break out page allocation warning code
Date: Fri, 8 Apr 2011 22:54:34 +0200 [thread overview]
Message-ID: <BANLkTi=OnDX53nOZcaaMmqXRBcWicam0xg@mail.gmail.com> (raw)
In-Reply-To: <20110408202253.6D6D231C@kernel>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Apr 8, 2011 10:23 PM, "Dave Hansen" <dave@linux.vnet.ibm.com> wrote:
> + if (fmt) {
> + printk(KERN_WARNING);
> + va_start(args, fmt);
> + r = vprintk(fmt, args);
> + va_end(args);
> + }
Could we make the "printk(KERN_WARNING);" go away and require caller to
specify level?
> + printk(KERN_WARNING);
> + printk("%s: page allocation failure: order:%d, mode:0x%x\n",
> + current->comm, order, gfp_mask);
Even more so here. Why not pr_warning instead of two non-atomic calls to
printk?
[-- Attachment #2: Type: text/html, Size: 825 bytes --]
next prev parent reply other threads:[~2011-04-08 20:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 20:22 [PATCH 1/2] break out page allocation warning code Dave Hansen
2011-04-08 20:22 ` [PATCH 2/2] print vmalloc() state after allocation failures Dave Hansen
2011-04-08 20:39 ` David Rientjes
2011-04-08 20:47 ` Dave Hansen
2011-04-08 20:37 ` [PATCH 1/2] break out page allocation warning code David Rientjes
2011-04-08 20:43 ` Dave Hansen
2011-04-08 20:54 ` Michał Nazarewicz [this message]
2011-04-08 21:02 ` Dave Hansen
2011-04-11 10:20 ` Michal Nazarewicz
-- strict thread matches above, loose matches on Subject: below --
2011-04-15 17:04 Dave Hansen
2011-04-17 0:02 ` David Rientjes
2011-04-18 15:10 ` Dave Hansen
2011-04-18 20:25 ` David Rientjes
2011-04-18 20:57 ` Dave Hansen
2011-04-19 21:23 ` David Rientjes
2011-04-18 21:03 ` Dave Hansen
2011-04-18 21:22 ` Dave Hansen
2011-04-19 0:44 ` KOSAKI Motohiro
2011-04-19 21:21 ` David Rientjes
2011-04-20 0:39 ` KOSAKI Motohiro
2011-04-20 20:24 ` David Rientjes
2011-04-20 20:34 ` john stultz
2011-04-21 1:29 ` KOSAKI Motohiro
2011-04-25 4:21 ` KOSAKI Motohiro
2011-04-26 19:27 ` john stultz
2011-04-27 23:51 ` David Rientjes
2011-04-28 0:32 ` john stultz
2011-04-28 1:29 ` john stultz
2011-04-28 22:48 ` David Rientjes
2011-04-28 23:48 ` john stultz
2011-04-29 0:04 ` john stultz
2011-04-26 21:25 ` john stultz
2011-04-28 3:05 ` KOSAKI Motohiro
2011-04-20 1:41 ` Dave Hansen
2011-04-20 1:50 ` KOSAKI Motohiro
2011-04-20 2:19 ` KOSAKI Motohiro
2011-04-20 2:46 ` Dave Hansen
2011-04-19 16:21 Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=OnDX53nOZcaaMmqXRBcWicam0xg@mail.gmail.com' \
--to=mnazarewicz@gmail.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).