From: Pekka Enberg <penberg@kernel.org>
To: Matt Mackall <mpm@selenic.com>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, "David S. Miller" <davem@davemloft.net>,
netfilter@vger.kernel.org
Subject: Re: [PATCH] slob: push the min alignment to long long
Date: Wed, 15 Jun 2011 23:40:05 +0300 [thread overview]
Message-ID: <BANLkTi=QG3ywRhSx=npioJx-d=yyf=o29A@mail.gmail.com> (raw)
In-Reply-To: <1308169466.15617.378.camel@calx>
On Wed, Jun 15, 2011 at 11:24 PM, Matt Mackall <mpm@selenic.com> wrote:
> On Wed, 2011-06-15 at 22:12 +0200, Sebastian Andrzej Siewior wrote:
>> * Matt Mackall | 2011-06-14 17:05:40 [-0500]:
>>
>> >Ok, so you claim that ARCH_KMALLOC_MINALIGN is not set on some
>> >architectures, and thus SLOB does the wrong thing.
>> >
>> >Doesn't that rather obviously mean that the affected architectures
>> >should define ARCH_KMALLOC_MINALIGN? Because, well, they have an
>> >"architecture-specific minimum kmalloc alignment"?
>>
>> nope, if nothing is defined SLOB asumes that alignment of long is the way
>> go. Unfortunately alignment of u64 maybe larger than of u32.
>
> I understand that. I guess we have a different idea of what constitutes
> "architecture-specific" and what constitutes "normal".
>
> But I guess I can be persuaded that most architectures now expect 64-bit
> alignment of u64s.
Changing the alignment for everyone is likely to cause less problems
in the future. Matt, are there any practical reasons why we shouldn't
do that?
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-15 20:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 20:10 [PATCH] slob: push the min alignment to long long Sebastian Andrzej Siewior
2011-06-14 20:40 ` Christoph Lameter
2011-06-14 21:16 ` Christoph Lameter
2011-06-15 20:06 ` Sebastian Andrzej Siewior
2011-06-16 16:48 ` Pekka Enberg
2011-06-22 23:41 ` David Rientjes
2011-06-23 14:36 ` Christoph Lameter
2011-06-23 20:24 ` David Rientjes
2011-06-14 22:05 ` Matt Mackall
2011-06-15 20:12 ` Sebastian Andrzej Siewior
2011-06-15 20:24 ` Matt Mackall
2011-06-15 20:40 ` Pekka Enberg [this message]
2011-06-15 20:55 ` Matt Mackall
2011-06-15 22:11 ` David Miller
2011-06-15 22:53 ` Matt Mackall
2011-06-16 6:59 ` Pekka Enberg
2011-06-16 15:23 ` Matt Mackall
2011-06-16 15:28 ` Pekka Enberg
2011-06-15 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=QG3ywRhSx=npioJx-d=yyf=o29A@mail.gmail.com' \
--to=penberg@kernel.org \
--cc=cl@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=netfilter@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).