From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 088466B0011 for ; Sun, 22 May 2011 19:31:39 -0400 (EDT) Received: by qyk30 with SMTP id 30so3732960qyk.14 for ; Sun, 22 May 2011 16:31:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 23 May 2011 08:31:35 +0900 Message-ID: Subject: Re: [PATCH mmotm] add the pagefault count into memcg stats: shmem fix From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Andrew Morton , Ying Han , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Daisuke Nishimura , Balbir Singh , linux-mm@kvack.org On Wed, May 18, 2011 at 3:24 AM, Hugh Dickins wrote: > mem_cgroup_count_vm_event() should update the PGMAJFAULT count for the > target mm, not for current mm (but of course they're usually the same). > > We don't know the target mm in shmem_getpage(), so do it at the outer > level in shmem_fault(); and it's easier to follow if we move the > count_vm_event(PGMAJFAULT) there too. > > Hah, it was using __count_vm_event() before, sneaking that update into > the unpreemptible section under info->lock: well, it comes to the same > on x86 at least, and I still think it's best to keep these together. > > Signed-off-by: Hugh Dickins Reviewed-by: Minchan Kim I am okay if memcg maintainer knew behavior change of shmem fault accounting. What I want was let memcg maintainer know slight behavior change. Thanks, Hugh. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org