From: Hiroyuki Kamezawa <kamezawa.hiroyuki@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"bsingharora@gmail.com" <bsingharora@gmail.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Ying Han <yinghan@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [-git build bug, PATCH] Re: [BUGFIX][PATCH 2/5] memcg: fix init_page_cgroup nid with sparsemem
Date: Thu, 16 Jun 2011 22:01:25 +0900 [thread overview]
Message-ID: <BANLkTik8oETUSphYDfP8g8CgyHnDcaBXOg@mail.gmail.com> (raw)
In-Reply-To: <20110616100937.GA12317@elte.hu>
2011/6/16 Ingo Molnar <mingo@elte.hu>:
>
> * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
>> Date: Mon, 13 Jun 2011 10:09:17 +0900
>> Subject: [PATCH 2/5] [BUGFIX] memcg: fix init_page_cgroup nid with sparsemem
>
> This fresh upstream commit commit:
>
> 37573e8c7182: memcg: fix init_page_cgroup nid with sparsemem
>
> is causing widespread build failures on latest -git, on x86:
>
> mm/page_cgroup.c:308:3: error: implicit declaration of function ‘node_start_pfn’ [-Werror=implicit-function-declaration]
> mm/page_cgroup.c:309:3: error: implicit declaration of function ‘node_end_pfn’ [-Werror=implicit-function-declaration]
>
> On any config that has CONFIG_CGROUP_MEM_RES_CTLR=y enabled but
> CONFIG_NUMA disabled.
>
> For now i've worked it around with the patch below, but the real
> solution would be to make the page_cgroup.c code not depend on NUMA.
>
> Thanks,
>
> Ingo
>
yes, very sorry. I'm now preparing a fix in this thread.
http://marc.info/?t=130819986800002&r=1&w=2
I think I'll be able to post a final fix, tomorrow. I'll cc you when I'll post.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-16 13:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 3:00 [BUGFIX][PATCH 0/5] memcg bugfixes in the last week KAMEZAWA Hiroyuki
2011-06-13 3:03 ` [BUGFIX][PATCH 1/5] memcg fix numa_stat permission KAMEZAWA Hiroyuki
2011-06-14 9:42 ` Johannes Weiner
2011-06-13 3:06 ` [BUGFIX][PATCH 2/5] memcg: fix init_page_cgroup nid with sparsemem KAMEZAWA Hiroyuki
2011-06-14 9:44 ` Johannes Weiner
2011-06-16 10:09 ` [-git build bug, PATCH] " Ingo Molnar
2011-06-16 13:01 ` Hiroyuki Kamezawa [this message]
2011-06-13 3:09 ` [BUGFIX][PATCH 3/5] memcg: clear mm->owner when last possible owner leaves KAMEZAWA Hiroyuki
2011-06-14 9:45 ` Johannes Weiner
2011-06-13 3:11 ` [BUGFIX][PATCH 4/5] memcg: fix wrong check of noswap with softlimit KAMEZAWA Hiroyuki
2011-06-14 9:48 ` Johannes Weiner
2011-06-13 3:16 ` [BUGFIX][PATCH 5/5] memcg: fix percpu cached charge draining frequency KAMEZAWA Hiroyuki
2011-06-13 21:25 ` Andrew Morton
2011-06-15 0:09 ` KAMEZAWA Hiroyuki
2011-06-15 1:19 ` Andrew Morton
2011-06-14 7:36 ` Michal Hocko
2011-06-15 0:12 ` KAMEZAWA Hiroyuki
2011-06-15 1:12 ` KAMEZAWA Hiroyuki
2011-06-15 7:15 ` Michal Hocko
2011-06-14 10:04 ` Johannes Weiner
2011-06-15 0:16 ` KAMEZAWA Hiroyuki
2011-06-15 1:49 ` [BUGFIX][PATCH v6] " KAMEZAWA Hiroyuki
2011-06-15 1:52 ` [BUGFIX][PATCH v2] memcg: avoid percpu cached charge draining at softlimit KAMEZAWA Hiroyuki
2011-06-15 5:30 ` [BUGFIX][PATCH v6] memcg: fix percpu cached charge draining frequency Ying Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik8oETUSphYDfP8g8CgyHnDcaBXOg@mail.gmail.com \
--to=kamezawa.hiroyuki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=mingo@elte.hu \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=torvalds@linux-foundation.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).