On Tue, Apr 19, 2011 at 5:20 PM, KOSAKI Motohiro <
kosaki.motohiro@jp.fujitsu.com> wrote:

> > This patch changes the shrink_slab and shrinker APIs by consolidating
> existing
> > parameters into scan_control struct. This simplifies any further attempts
> to
> > pass extra info to the shrinker. Instead of modifying all the shrinker
> files
> > each time, we just need to extend the scan_control struct.
> >
>
> Ugh. No, please no.
> Current scan_control has a lot of vmscan internal information. Please
> export only you need one, not all.
>
> Otherwise, we can't change any vmscan code while any shrinker are using it.
>

So, are you suggesting maybe add another struct for this purpose?

--Ying