From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id EE31E9000C1 for ; Tue, 26 Apr 2011 06:18:59 -0400 (EDT) Received: by gxk23 with SMTP id 23so239123gxk.14 for ; Tue, 26 Apr 2011 03:18:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20110426055521.GA18473@localhost> <20110426062535.GB19717@localhost> <20110426063421.GC19717@localhost> <20110426092029.GA27053@localhost> Date: Tue, 26 Apr 2011 13:18:55 +0300 Message-ID: Subject: Re: readahead and oom From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Wu Fengguang , Dave Young , linux-mm , Linux Kernel Mailing List , Andrew Morton , Mel Gorman On Tue, Apr 26, 2011 at 12:28 PM, Minchan Kim wrote= : > On Tue, Apr 26, 2011 at 6:20 PM, Wu Fengguang wr= ote: >> Minchan, >> >>> > +static inline struct page *page_cache_alloc_cold_noretry(struct addr= ess_space *x) >>> > +{ >>> > + =A0 =A0 =A0 return __page_cache_alloc(mapping_gfp_mask(x)|__GFP_COL= D|__GFP_NORETRY); >>> >>> It makes sense to me but it could make a noise about page allocation >>> failure. I think it's not desirable. >>> How about adding __GFP_NOWARAN? >> >> Yeah it makes sense. Here is the new version. >> >> Thanks, >> Fengguang >> --- >> Subject: readahead: readahead page allocations is OK to fail >> Date: Tue Apr 26 14:29:40 CST 2011 >> >> Pass __GFP_NORETRY|__GFP_NOWARN for readahead page allocations. >> >> readahead page allocations are completely optional. They are OK to >> fail and in particular shall not trigger OOM on themselves. >> >> Reported-by: Dave Young >> Reviewed-by: KOSAKI Motohiro >> Signed-off-by: Wu Fengguang > Reviewed-by: Minchan Kim Reviewed-by: Pekka Enberg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org