From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id E3B378D003B for ; Sun, 24 Apr 2011 22:08:23 -0400 (EDT) Received: from kpbe14.cbf.corp.google.com (kpbe14.cbf.corp.google.com [172.25.105.78]) by smtp-out.google.com with ESMTP id p3P28LgT012980 for ; Sun, 24 Apr 2011 19:08:21 -0700 Received: from qyk2 (qyk2.prod.google.com [10.241.83.130]) by kpbe14.cbf.corp.google.com with ESMTP id p3P28IcJ007196 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Sun, 24 Apr 2011 19:08:20 -0700 Received: by qyk2 with SMTP id 2so655908qyk.14 for ; Sun, 24 Apr 2011 19:08:18 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110425082642.034a5f64.kamezawa.hiroyu@jp.fujitsu.com> References: <1303446260-21333-1-git-send-email-yinghan@google.com> <1303446260-21333-5-git-send-email-yinghan@google.com> <20110422133643.6a36d838.kamezawa.hiroyu@jp.fujitsu.com> <20110422140023.949e5737.kamezawa.hiroyu@jp.fujitsu.com> <20110422145943.a8f5a4ef.kamezawa.hiroyu@jp.fujitsu.com> <20110422164622.a8350bc5.kamezawa.hiroyu@jp.fujitsu.com> <20110425082642.034a5f64.kamezawa.hiroyu@jp.fujitsu.com> Date: Sun, 24 Apr 2011 19:08:17 -0700 Message-ID: Subject: Re: [PATCH V7 4/9] Add memcg kswapd thread pool From: Ying Han Content-Type: multipart/alternative; boundary=000e0ce008bc50ff2504a1b4aef9 Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: KOSAKI Motohiro , Minchan Kim , Daisuke Nishimura , Balbir Singh , Tejun Heo , Pavel Emelyanov , Andrew Morton , Li Zefan , Mel Gorman , Christoph Lameter , Johannes Weiner , Rik van Riel , Hugh Dickins , Michal Hocko , Dave Hansen , Zhu Yanhai , linux-mm@kvack.org --000e0ce008bc50ff2504a1b4aef9 Content-Type: text/plain; charset=ISO-8859-1 On Sun, Apr 24, 2011 at 4:26 PM, KAMEZAWA Hiroyuki < kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Fri, 22 Apr 2011 00:59:26 -0700 > Ying Han wrote: > > > On Fri, Apr 22, 2011 at 12:46 AM, KAMEZAWA Hiroyuki < > > kamezawa.hiroyu@jp.fujitsu.com> wrote: > > > > From this, I feel I need to use unbound workqueue. BTW, with patches > for > > > current thread pool model, I think starvation problem by dirty pages > > > cannot be seen. > > > Anyway, I'll give a try. > > > > > > > Then do you suggest me to wait for your patch for my next post? > > > > I used most of weekend for background reclaim on workqueue and I changed > many > things based on your patch (but dropped most of kswapd > descriptor...patches.) > > Thank you for the heads up. Although I am still having concerns on the workqueue approach, but thank you for your time to give a try. One of my concerns is still the debug-ability and I am not being convinced the resource consumption is a killing issue for the per-memcg kswapd thread. Anyway, looking to see your change. --Ying > I'll post it today after some tests on machines in my office. It worked > well > on my laptop. > > Thanks, > -Kame > > --000e0ce008bc50ff2504a1b4aef9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Sun, Apr 24, 2011 at 4:26 PM, KAMEZAW= A Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
On Fri, 22 Apr 2011 00:59:26 -0700
Ying Han <yingha= n@google.com> wrote:

> On Fri, Apr 22, 2011 at 12:46 AM, KAMEZAWA Hir= oyuki <
> kamezawa.hiroyu@jp.f= ujitsu.com> wrote:

> > From this, I feel I need to use unbound w= orkqueue. BTW, with patches for
> > current thread pool model, I think starvation problem by dirty pa= ges
> > cannot be seen.
> > Anyway, I'll give a try.
> >
>
> Then do you suggest me to wait for your patch for my next post?
>

I used most of weekend for background reclaim on workqueue and I chan= ged many
things based on your patch (but dropped most of kswapd descriptor...patches= .)

Thank you for the heads up. Although I am still havin= g concerns on the workqueue approach, but=A0
thank you for your t= ime to give a try.=A0

One of my concerns is still = the=A0debug-ability and I am not being=A0convinced the resource consumption= is a killing issue for the per-memcg
kswapd thread. Anyway, looking to see your change.

--Ying =A0

=A0
I'll post it today after some tests on machines in my office. It worked= well
on my laptop.

Thanks,
-Kame


--000e0ce008bc50ff2504a1b4aef9-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org