From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 75A576B0078 for ; Thu, 9 Jun 2011 06:21:55 -0400 (EDT) Received: by qwa26 with SMTP id 26so902065qwa.14 for ; Thu, 09 Jun 2011 03:21:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1307606573-24704-11-git-send-email-mgorman@suse.de> References: <1307606573-24704-1-git-send-email-mgorman@suse.de> <1307606573-24704-11-git-send-email-mgorman@suse.de> From: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= Date: Thu, 9 Jun 2011 12:21:31 +0200 Message-ID: Subject: Re: [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Andrew Morton , Linux-MM , Linux-Netdev , LKML , David Miller , Neil Brown , Peter Zijlstra 2011/6/9 Mel Gorman : [...] > +/* > + * Limit which protocols can use the PFMEMALLOC reserves to those that a= re > + * expected to be used for communication with swap. > + */ > +static bool skb_pfmemalloc_protocol(struct sk_buff *skb) > +{ > + =A0 =A0 =A0 switch (skb->protocol) { > + =A0 =A0 =A0 case __constant_htons(ETH_P_ARP): > + =A0 =A0 =A0 case __constant_htons(ETH_P_IP): > + =A0 =A0 =A0 case __constant_htons(ETH_P_IPV6): > + =A0 =A0 =A0 case __constant_htons(ETH_P_8021Q): > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return true; > + =A0 =A0 =A0 default: > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return false; > + =A0 =A0 =A0 } > +} This is not needed and wrong. Whatever list there will be, it's going to always miss some obscure setup (or not that obscure, like ATAoverEthernet). Best Regards, Micha=B3 Miros=B3aw -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org