From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id D20DC6B0011 for ; Sun, 15 May 2011 15:56:46 -0400 (EDT) Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id p4FJujY1031632 for ; Sun, 15 May 2011 12:56:45 -0700 Received: from qyj19 (qyj19.prod.google.com [10.241.83.83]) by wpaz5.hot.corp.google.com with ESMTP id p4FJuiG1008933 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Sun, 15 May 2011 12:56:44 -0700 Received: by qyj19 with SMTP id 19so1131140qyj.9 for ; Sun, 15 May 2011 12:56:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110513190458.ddc0fbe2.kamezawa.hiroyu@jp.fujitsu.com> References: <1305276473-14780-1-git-send-email-gthelen@google.com> <1305276473-14780-12-git-send-email-gthelen@google.com> <20110513190458.ddc0fbe2.kamezawa.hiroyu@jp.fujitsu.com> From: Greg Thelen Date: Sun, 15 May 2011 12:56:24 -0700 Message-ID: Subject: Re: [RFC][PATCH v7 11/14] memcg: create support routines for writeback Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, linux-fsdevel@vger.kernel.org, Andrea Righi , Balbir Singh , Daisuke Nishimura , Minchan Kim , Johannes Weiner , Ciju Rajan K , David Rientjes , Wu Fengguang , Vivek Goyal , Dave Chinner On Fri, May 13, 2011 at 3:04 AM, KAMEZAWA Hiroyuki wrote: > On Fri, 13 May 2011 01:47:50 -0700 > Greg Thelen wrote: > >> Introduce memcg routines to assist in per-memcg writeback: >> >> - mem_cgroups_over_bground_dirty_thresh() determines if any cgroups need >> =A0 writeback because they are over their dirty memory threshold. >> >> - should_writeback_mem_cgroup_inode() determines if an inode is >> =A0 contributing pages to an over-limit memcg. >> >> - mem_cgroup_writeback_done() is used periodically during writeback to >> =A0 update memcg writeback data. >> >> Signed-off-by: Greg Thelen > > Reviewed-by: KAMEZAWA Hiroyuki > > I'm okay with the bitmap..then, problem will be when set/clear wbc->for_c= group... wbc->for_cgroup is only set in two conditions: a) when mem_cgroup_balance_dirty_pages() is trying to get a cgroup below its dirty memory foreground threshold. This is in patch 12/14. b) when bdi-flusher is performing background writeback and determines that at any of the cgroup are over their respective background dirty memory threshold. This is in patch 13/14. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org