From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 9AD35900001 for ; Thu, 28 Apr 2011 19:51:34 -0400 (EDT) Received: by bwz17 with SMTP id 17so4176415bwz.14 for ; Thu, 28 Apr 2011 16:51:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1304030226-19332-1-git-send-email-yinghan@google.com> <1304030226-19332-3-git-send-email-yinghan@google.com> Date: Fri, 29 Apr 2011 08:51:29 +0900 Message-ID: Subject: Re: [PATCH 2/2] Add stats to monitor soft_limit reclaim From: Hiroyuki Kamezawa Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Ying Han Cc: KOSAKI Motohiro , Minchan Kim , Daisuke Nishimura , Balbir Singh , Tejun Heo , Pavel Emelyanov , KAMEZAWA Hiroyuki , Andrew Morton , Li Zefan , Mel Gorman , Christoph Lameter , Johannes Weiner , Rik van Riel , Hugh Dickins , Michal Hocko , Dave Hansen , Zhu Yanhai , linux-mm@kvack.org 2011/4/29 Ying Han : > On Thu, Apr 28, 2011 at 3:37 PM, Ying Han wrote: >> This patch extend the soft_limit reclaim stats to both global background >> reclaim and global direct reclaim. >> >> We have a thread discussing the naming of some of the stats. Both >> KAMEZAWA and Johannes posted the proposals. The following stats are base= d >> on what i had before that thread. I will make the corresponding change o= n >> the next post when we make decision. >> >> $cat /dev/cgroup/memory/A/memory.stat >> kswapd_soft_steal 1053626 >> kswapd_soft_scan 1053693 >> direct_soft_steal 1481810 >> direct_soft_scan 1481996 >> >> Signed-off-by: Ying Han >> --- >> =A0Documentation/cgroups/memory.txt | =A0 10 ++++- >> =A0mm/memcontrol.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 68 +++++++++= +++++++++++++++++++---------- >> =A02 files changed, 58 insertions(+), 20 deletions(-) >> >> diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/me= mory.txt >> index 0c40dab..fedc107 100644 >> --- a/Documentation/cgroups/memory.txt >> +++ b/Documentation/cgroups/memory.txt >> @@ -387,8 +387,14 @@ pgpgout =A0 =A0 =A0 =A0 =A0 =A0- # of pages paged o= ut (equivalent to # of uncharging events). >> =A0swap =A0 =A0 =A0 =A0 =A0 - # of bytes of swap usage >> =A0pgfault =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0- # of page faults. >> =A0pgmajfault =A0 =A0 - # of major page faults. >> -soft_steal =A0 =A0 - # of pages reclaimed from global hierarchical recl= aim >> -soft_scan =A0 =A0 =A0- # of pages scanned from global hierarchical recl= aim >> +soft_kswapd_steal- # of pages reclaimed in global hierarchical reclaim = from >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 background reclaim >> +soft_kswapd_scan - # of pages scanned in global hierarchical reclaim fr= om >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 background reclaim >> +soft_direct_steal- # of pages reclaimed in global hierarchical reclaim = from >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 direct reclaim >> +soft_direct_scan- # of pages scanned in global hierarchical reclaim fro= m >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 direct reclaim Thank you for CC. I don't have strong opinion but once we add interfaces to mainline, it's hard to rename them. So, it's better to make a list of what name we'll need in future. Now, your naming has a format as [Reason]-[Who reclaim]-[What count?] soft_kswapd_steal soft_kswapd_scan soft_direct_steal soft_direct_scan Ok, we can make a name for wmark and limit reclaim as limit_direct_steal/scan wmark_bg_steal/scan Then, assume we finally do round-robin scan of memcg regardless of softlimi= t by removing global LRU, what name do we have ? Hmm, kernel_kswapd_scan/steal kernel_direct_scan/steal ? BTW, your changelog has different name of counters. please fix. And I'm sorry I'll not be very active for a while. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org