From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 3C661900086 for ; Mon, 18 Apr 2011 23:46:24 -0400 (EDT) Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id p3J3kF3v001632 for ; Mon, 18 Apr 2011 20:46:20 -0700 Received: from qyk2 (qyk2.prod.google.com [10.241.83.130]) by wpaz21.hot.corp.google.com with ESMTP id p3J3kEvO011265 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 18 Apr 2011 20:46:14 -0700 Received: by qyk2 with SMTP id 2so3976466qyk.2 for ; Mon, 18 Apr 2011 20:46:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1302821669-29862-1-git-send-email-yinghan@google.com> <20110415094040.GC8828@tiehlicka.suse.cz> <20110418091351.GC8925@tiehlicka.suse.cz> <20110418184240.GA11653@tiehlicka.suse.cz> Date: Mon, 18 Apr 2011 20:46:14 -0700 Message-ID: Subject: Re: [PATCH V4 00/10] memcg: per cgroup background reclaim From: Ying Han Content-Type: multipart/alternative; boundary=0023544706748c1c4a04a13d5971 Sender: owner-linux-mm@kvack.org List-ID: To: Zhu Yanhai Cc: Michal Hocko , KOSAKI Motohiro , Minchan Kim , Daisuke Nishimura , Balbir Singh , Tejun Heo , Pavel Emelyanov , KAMEZAWA Hiroyuki , Andrew Morton , Li Zefan , Mel Gorman , Christoph Lameter , Johannes Weiner , Rik van Riel , Hugh Dickins , Dave Hansen , linux-mm@kvack.org --0023544706748c1c4a04a13d5971 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Apr 18, 2011 at 7:48 PM, Zhu Yanhai wrote: > Hi, > > 2011/4/19 Ying Han : > > > > that is true. I adopt the initial comment from Mel where we keep the > same > > logic of triggering and stopping kswapd with low/high_wmarks and also > > comparing the usage_in_bytes to the wmarks. Either way is confusing and > > guess we just need to document it well. > > IMO another thing need to document well is that a user must setup > high_wmark_distance before setup low_wmark_distance to to make it > start work, and zero low_wmark_distance before zero > high_wmark_distance to stop it. Otherwise it won't pass the sanity > check, which is not quite obvious. > yes. will add into the document. --Ying > > Thanks, > Zhu Yanhai > > > --Ying > >> > >> -- > >> Michal Hocko > >> SUSE Labs > >> SUSE LINUX s.r.o. > >> Lihovarska 1060/12 > >> 190 00 Praha 9 > >> Czech Republic > > > > > --0023544706748c1c4a04a13d5971 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Mon, Apr 18, 2011 at 7:48 PM, Zhu Yan= hai <zhu.yanha= i@gmail.com> wrote:
Hi,

2011/4/19 Ying Han <yinghan@google= .com>:
>
> that is true. =A0I adopt the initial comment from Mel where we keep th= e same
> logic of triggering and stopping kswapd with low/high_wmarks and also<= br> > comparing the usage_in_bytes to the wmarks.=A0Either way is confusing = and
> guess we just need to document it well.

IMO another thing need to document well is that a user must setup
high_wmark_distance before setup low_wmark_distance to to make it
start work, and zero =A0low_wmark_distance before zero
high_wmark_distance to stop it. Otherwise it won't pass the sanity
check, which is not quite obvious.

yes.= will add into the document.

--Ying=A0

Thanks,
Zhu Yanhai

> --Ying
>>
>> --
>> Michal Hocko
>> SUSE Labs
>> SUSE LINUX s.r.o.
>> Lihovarska 1060/12
>> 190 00 Praha 9
>> Czech Republic
>
>

--0023544706748c1c4a04a13d5971-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org