Re: [PATCH] Stack trace dedup

[Ying Han <yinghan@google.com>]

On Tue, Mar 29, 2011 at 6:21 PM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
>> This doesn't build.
>> ---
>>  arch/x86/Kconfig                  |    3 +
>>  arch/x86/include/asm/stacktrace.h |    2 +-
>>  arch/x86/kernel/dumpstack.c       |    5 +-
>>  arch/x86/kernel/dumpstack_64.c    |   10 +++-
>>  arch/x86/kernel/stacktrace.c      |  108 +++++++++++++++++++++++++++++++++++++
>>  include/linux/sched.h             |   10 +++-
>>  init/main.c                       |    1 +
>>  kernel/sched.c                    |   25 ++++++++-
>>  8 files changed, 154 insertions(+), 10 deletions(-)
>
> This is slightly reticence changelog. Can you please explain a purpose
> and benefit?

Hi:

Sorry about the spam. This is a patch that I was preparing to send
upstream but not ready yet. I don't know why it got sent out ( must be
myself did something wrong on my keyboard ) .

In a short, this eliminate the duplication of task stack trace in dump
messages. The problem w/ fixed size of dmesg ring buffer limits how
many task trace to be logged. When the duplication remains high, we
lose important information. This patch reduces the duplication by
dumping the first task stack trace only for contiguous duplications.

I will prepare it later with full commit description.

Thanks

--Ying


>
>
>
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>