From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 6D1E98D003B for ; Sun, 24 Apr 2011 01:37:14 -0400 (EDT) Received: by iyh42 with SMTP id 42so1845796iyh.14 for ; Sat, 23 Apr 2011 22:37:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1303604751-4980-1-git-send-email-minchan.kim@gmail.com> References: <1303604751-4980-1-git-send-email-minchan.kim@gmail.com> Date: Sun, 24 Apr 2011 14:37:12 +0900 Message-ID: Subject: Re: [PATCH] Check PageActive when evictable page and unevicetable page race happen From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-mm , LKML , Minchan Kim , Rik van Riel , KOSAKI Motohiro , Hugh Dickins , Johannes Weiner , Lee Schermerhorn On Sun, Apr 24, 2011 at 9:25 AM, Minchan Kim wrote: > In putback_lru_page, unevictable page can be changed into evictable > 's one while we move it among lru. So we have checked it again and > rescued it. But we don't check PageActive, again. It could add > active page into inactive list so we can see the BUG in isolate_lru_pages. > (But I didn't see any report because I think it's very subtle) > > It could happen in race that zap_pte_range's mark_page_accessed and > putback_lru_page. It's subtle but could be possible. Please Ignore this. I was confused. The race never happens. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org