From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id 1F49F6B0012 for ; Tue, 14 Jun 2011 07:16:11 -0400 (EDT) Received: by vxk20 with SMTP id 20so6087242vxk.14 for ; Tue, 14 Jun 2011 04:16:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 14 Jun 2011 14:16:09 +0300 Message-ID: Subject: Re: [PATCH 11/12] tmpfs: use kmemdup for short symlinks From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Tue, Jun 14, 2011 at 1:57 PM, Hugh Dickins wrote: > But we've not yet removed the old swp_entry_t i_direct[16] from > shmem_inode_info. =A0That's because it was still being shared with the > inline symlink. =A0Remove it now (saving 64 or 128 bytes from shmem inode > size), and use kmemdup() for short symlinks, say, those up to 128 bytes. > > I wonder why mpol_free_shared_policy() is done in shmem_destroy_inode() > rather than shmem_evict_inode(), where we usually do such freeing? =A0I > guess it doesn't matter, and I'm not into NUMA mpol testing right now. > > Signed-off-by: Hugh Dickins Reviewed-by: Pekka Enberg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org