Re: [PATCH] memcg: fix typo in the soft_limit stats.

[Ying Han <yinghan@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On Mon, May 16, 2011 at 4:15 PM, Johannes Weiner <hannes@cmpxchg.org> wrote:

> On Mon, May 16, 2011 at 03:00:30PM -0700, Ying Han wrote:
> > This fixes the typo in the memory.stat including the following two
> > stats:
> >
> > $ cat /dev/cgroup/memory/A/memory.stat
> > total_soft_steal 0
> > total_soft_scan 0
> >
> > And change it to:
> >
> > $ cat /dev/cgroup/memory/A/memory.stat
> > total_soft_kswapd_steal 0
> > total_soft_kswapd_scan 0
> >
> > Signed-off-by: Ying Han <yinghan@google.com>
>
> I am currently proposing and working on a scheme that makes the soft
> limit not only a factor for global memory pressure, but for
> hierarchical reclaim in general, to prefer child memcgs during reclaim
> that are in excess of their soft limit.
>
> Because this means prioritizing memcgs over one another, rather than
> having explicit soft limit reclaim runs, there is no natural counter
> for pages reclaimed due to the soft limit anymore.
>
> Thus, for the patch that introduces this counter:
>
> Nacked-by: Johannes Weiner <hannes@cmpxchg.org>
>

This patch is fixing a typo of the stats being integrated into mmotm. Does
it make sense to fix the
existing stats first while we are discussing other approaches?

--Ying

[-- Attachment #2: Type: text/html, Size: 1770 bytes --]