From: William Kucharski <william.kucharski@oracle.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Michal Hocko <mhocko@kernel.org>, Yufen Yu <yuyufen@huawei.com>,
linux-mm@kvack.org, kirill.shutemov@linux.intel.com,
n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH v2] hugetlbfs: fix protential null pointer dereference
Date: Mon, 15 Apr 2019 04:26:02 -0600 [thread overview]
Message-ID: <C17929E9-6685-4D53-9F9F-1C147D63A95E@oracle.com> (raw)
In-Reply-To: <ce422d2b-dd9d-e878-750d-499b9a21c847@oracle.com>
> On Apr 11, 2019, at 12:40 PM, Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> You are right. That would make more sense. It has been a while since I
> looked into that code and unfortunately I did not save notes. I'll do some
> research to come up with an appropriate explanation/comment.
I also like the idea of a comment rather than code here.
Zero run time impact and more importantly it instantly explains to everyone
why this case is different rather than just adding the check for the sake of
uniformity.
prev parent reply other threads:[~2019-04-15 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 3:53 [PATCH v2] hugetlbfs: fix protential null pointer dereference Yufen Yu
2019-04-11 8:19 ` Michal Hocko
2019-04-11 16:52 ` Mike Kravetz
2019-04-11 18:22 ` Michal Hocko
2019-04-11 18:40 ` Mike Kravetz
2019-04-11 18:49 ` Michal Hocko
2019-04-15 10:26 ` William Kucharski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C17929E9-6685-4D53-9F9F-1C147D63A95E@oracle.com \
--to=william.kucharski@oracle.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).