From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C6EDC43334 for ; Fri, 22 Jul 2022 17:21:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11BBD6B0074; Fri, 22 Jul 2022 13:21:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A5F26B0075; Fri, 22 Jul 2022 13:21:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E86B08E0001; Fri, 22 Jul 2022 13:21:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DAFF26B0074 for ; Fri, 22 Jul 2022 13:21:04 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ACFAD160CB4 for ; Fri, 22 Jul 2022 17:21:04 +0000 (UTC) X-FDA: 79715401248.23.18B0EF7 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf28.hostedemail.com (Postfix) with ESMTP id 4AA46C009E for ; Fri, 22 Jul 2022 17:21:04 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id pc13so4919706pjb.4 for ; Fri, 22 Jul 2022 10:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RrKXygvFpicOjR+psPeJKbRF/UGRv7RRF5bAbRJRjNI=; b=JfFbUTyuFt0o9gKtE5SxvX8n8GKZADW3sWVWl3dLIjfkaBNZLBjZQEmsa0h2Wjufq5 zkAIB5LAyt25RifUCwh4pBU0HzERfVBaZf93VsXqyoel5erekYp0QH4coLWfeT38nOoB IaZ4zCSEhF1I6mhgLWta1i0pDg+DEWbxvWD3dx1lXa9sR+5/wKhwGT6tAFgFT0ZleDo1 757tP/V4Qfg2QmBcOdDnWIyLnfRgzDpYFqhCy5aJ0tcF10A79ld3bK9WmdhkIyhPtAJu k3ZPM2P+p+dtfIo24doWPaB5P2yjxL7IjMok2cAcK2XBiJmXufg71mmdrm+THa2NMwVo kv3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RrKXygvFpicOjR+psPeJKbRF/UGRv7RRF5bAbRJRjNI=; b=dNKhYjEn09XP389gduo3VLKGO6QZb7b5EFB1klf1yUdRUGo+qo8uIyKK+d4wIiQKfp tjIGInvHMCoAGX/aJeBrt+LHTLi2/CedgXXvsDE7yDNYTYwT6SRp5LZMPaTVG/UcGeQ2 ytlRwpvMOCJUiecIZkMkLeW/2OsR0Dl/+62g7ABu8rMnsbUyOGDzk1npS60KriIKDGxv ivAR+uZnNgxHvuKGopKXGi0RBmnSS2GHlI20S8t2A4ewCq08ttJ8iqa7QDBuQuRpeoNL 6YKi7u33LX/gHXWjD1DaVTVig/gYUBxTtl033RBOLWLCQb+gON5Oye0Yl+a+gst7xZFD iGEw== X-Gm-Message-State: AJIora8QaJlqMkNQNRkNyLjfpI750YqPP7Vfc5L4UPfyYcqgkdZZRpWU e4hitbiTRD3kDY1GYOwTZ68= X-Google-Smtp-Source: AGRyM1sBTOWYfE1fH6K6lMdV7OfTxp7w+rM+UfrN0JmP5AA4H4BosQcPDUXL17lCUlfoP5fi4b3OIg== X-Received: by 2002:a17:90b:1e03:b0:1f2:518a:8f78 with SMTP id pg3-20020a17090b1e0300b001f2518a8f78mr3088041pjb.217.1658510462641; Fri, 22 Jul 2022 10:21:02 -0700 (PDT) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id z12-20020a63e54c000000b004119deff40dsm3765419pgj.23.2022.07.22.10.21.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2022 10:21:02 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v3 1/3] mm/mprotect: Fix soft-dirty check in can_change_pte_writable() From: Nadav Amit In-Reply-To: Date: Fri, 22 Jul 2022 10:21:00 -0700 Cc: Peter Xu , LKML , Linux MM , Andrew Morton , Andrea Arcangeli Content-Transfer-Encoding: 7bit Message-Id: References: <20220721183338.27871-1-peterx@redhat.com> <20220721183338.27871-2-peterx@redhat.com> To: David Hildenbrand X-Mailer: Apple Mail (2.3696.100.31) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658510464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RrKXygvFpicOjR+psPeJKbRF/UGRv7RRF5bAbRJRjNI=; b=bhrUn8wPnTehBmmkpA3oIO8WlSTIzCizYy8yAmjRI/iZGHcUiWEFG1CoAZqh2UcSr1IbUK gXFqfpw+UqASSGHWT0egpAStZWbkpheClmwSxe0+QmGX4efx3+Wsexy5ZLSzIfoeBZQBOt 0dh5t2y9pD587i6jyh8rKc5wknJKOeI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658510464; a=rsa-sha256; cv=none; b=CrurBRxyqqo3uaaJ0YUBRiLOQnvaW4eG5dcBvkxB0vVpIZmoYU5bEqlSC4tsFGJwZBF77W vuIk0HxS+ys/AlWmGVr3L1AAbRdYGnxJ4QZ37ENyCwf3IO7MHx7pCZA3ZCmNXBXfRgUeca scEL9zDuZxF/NDznbjzma94R+28pgVE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JfFbUTyu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JfFbUTyu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com X-Rspam-User: X-Rspamd-Queue-Id: 4AA46C009E X-Rspamd-Server: rspam06 X-Stat-Signature: s1jwodwazrchrh3qffj9kg8d8ek8894m X-HE-Tag: 1658510464-233207 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Jul 22, 2022, at 12:08 AM, David Hildenbrand wrote: >> +static inline bool vma_soft_dirty_enabled(struct vm_area_struct *vma) >> +{ >> + /* >> + * NOTE: we must check this before VM_SOFTDIRTY on soft-dirty >> + * enablements, because when without soft-dirty being compiled in, >> + * VM_SOFTDIRTY is defined as 0x0, then !(vm_flags & VM_SOFTDIRTY) >> + * will be constantly true. >> + */ >> + if (!IS_ENABLED(CONFIG_MEM_SOFT_DIRTY)) >> + return false; >> + >> + /* >> + * Soft-dirty is kind of special: its tracking is enabled when the >> + * vma flags not set. >> + */ >> + return !(vma->vm_flags & VM_SOFTDIRTY); >> +} > > That will come in handy in other patches I'm cooking. clear_refs_write() also comes to mind as well (for consistency; I see no correctness or performance issue).