From: Kees Cook <kees@kernel.org>
To: "Wojciech Gładysz" <wojciech.gladysz@infogain.com>,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
ebiederm@xmission.com, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/fs: last check for exec credentials on NOEXEC mount
Date: Thu, 01 Aug 2024 20:28:12 -0700 [thread overview]
Message-ID: <C96FCBBF-6D63-431F-AEA8-81B7937CB9B1@kernel.org> (raw)
In-Reply-To: <20240801120745.13318-1-wojciech.gladysz@infogain.com>
On August 1, 2024 5:07:45 AM PDT, "Wojciech Gładysz" <wojciech.gladysz@infogain.com> wrote:
>Test case: thread mounts NOEXEC fuse to a file being executed.
>WARN_ON_ONCE is triggered yielding panic for some config.
>Add a check to security_bprm_creds_for_exec(bprm).
As others have noted, this is racy. I would still like to keep the redundant check as-is, but let's lower it from WARN to pr_warn_ratelimited, since it's a known race that can be reached from userspace.
--
Kees Cook
prev parent reply other threads:[~2024-08-02 3:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 12:07 [PATCH] kernel/fs: last check for exec credentials on NOEXEC mount Wojciech Gładysz
2024-08-01 14:07 ` Josef Bacik
2024-08-01 15:15 ` Mateusz Guzik
2024-08-02 15:58 ` Josef Bacik
2024-08-03 6:29 ` Mateusz Guzik
2024-08-05 9:26 ` Christian Brauner
2024-08-05 13:17 ` [PATCH] exec: drop a racy path_noexec check Mateusz Guzik
2024-08-05 15:35 ` Christian Brauner
2024-08-05 20:21 ` Kees Cook
2024-08-05 23:38 ` Al Viro
2024-08-05 23:41 ` Al Viro
2024-08-06 7:06 ` Christian Brauner
2024-08-02 3:28 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C96FCBBF-6D63-431F-AEA8-81B7937CB9B1@kernel.org \
--to=kees@kernel.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wojciech.gladysz@infogain.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).