From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) by kanga.kvack.org (Postfix) with ESMTP id 5BBF96B0253 for ; Tue, 1 Dec 2015 12:19:06 -0500 (EST) Received: by igcto18 with SMTP id to18so11614705igc.0 for ; Tue, 01 Dec 2015 09:19:06 -0800 (PST) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com. [2607:f8b0:4001:c05::235]) by mx.google.com with ESMTPS id p15si14362246igx.102.2015.12.01.09.19.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Dec 2015 09:19:05 -0800 (PST) Received: by igvg19 with SMTP id g19so99088273igv.1 for ; Tue, 01 Dec 2015 09:19:05 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20151201171322.GD4341@pd.tnic> References: <1448404418-28800-1-git-send-email-toshi.kani@hpe.com> <1448404418-28800-2-git-send-email-toshi.kani@hpe.com> <20151201135000.GB4341@pd.tnic> <20151201171322.GD4341@pd.tnic> Date: Tue, 1 Dec 2015 09:19:05 -0800 Message-ID: Subject: Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() From: Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Borislav Petkov Cc: Dan Williams , Toshi Kani , Andrew Morton , "Rafael J. Wysocki" , Tony Luck , Vishal L Verma , Linux MM , "linux-nvdimm@lists.01.org" , Linux ACPI , "linux-kernel@vger.kernel.org" On Tue, Dec 1, 2015 at 9:13 AM, Borislav Petkov wrote: > > Oh sure, I didn't mean you. I was simply questioning that whole > identify-resource-by-its-name approach. And that came with: > > 67cf13ceed89 ("x86: optimize resource lookups for ioremap") > > I just think it is silly and that we should be identifying resource > things in a more robust way. I could easily imagine just adding a IORESOURCE_RAM flag (or SYSMEM or whatever). That sounds sane. I agree that comparing the string is ugly. > Btw, the ->name thing in struct resource has been there since a *long* > time It's pretty much always been there. It is indeed meant for things like /proc/iomem etc, and as a debug aid when printing conflicts, yadda yadda. Just showing the numbers is usually useless for figuring out exactly *what* something conflicts with. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org