From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by kanga.kvack.org (Postfix) with ESMTP id 361506B0070 for ; Tue, 22 Apr 2014 22:44:48 -0400 (EDT) Received: by mail-ve0-f182.google.com with SMTP id jw12so412268veb.27 for ; Tue, 22 Apr 2014 19:44:47 -0700 (PDT) Received: from mail-ve0-x232.google.com (mail-ve0-x232.google.com [2607:f8b0:400c:c01::232]) by mx.google.com with ESMTPS id b5si7205356vej.191.2014.04.22.19.44.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Apr 2014 19:44:47 -0700 (PDT) Received: by mail-ve0-f178.google.com with SMTP id jw12so389866veb.23 for ; Tue, 22 Apr 2014 19:44:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5356E33F.3000908@intel.com> References: <1398032742.19682.11.camel@pasglop> <1398054064.19682.32.camel@pasglop> <1398057630.19682.38.camel@pasglop> <53558507.9050703@zytor.com> <53559F48.8040808@intel.com> <20140422075459.GD11182@twins.programming.kicks-ass.net> <5356E33F.3000908@intel.com> Date: Tue, 22 Apr 2014 19:44:47 -0700 Message-ID: Subject: Re: Dirty/Access bits vs. page content From: Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: Peter Zijlstra , Hugh Dickins , "H. Peter Anvin" , Benjamin Herrenschmidt , "linux-arch@vger.kernel.org" , linux-mm , Russell King - ARM Linux , Tony Luck On Tue, Apr 22, 2014 at 2:46 PM, Dave Hansen wrote: > > The line numbers point to the > > head = page_buffers(page); Ahh. My tree has an ext4 update, so for me that wasn't the case, and your line numbers were off. Hmm. I've stared at it, and I can make neither heads nor tails of it. I really don't see why moving the set_page_dirty() would matter for that case. Very odd. I'll mull on it and maybe it comes to me overnight. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org