From: Linus Torvalds <torvalds@linux-foundation.org>
To: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Fengguang Wu <fengguang.wu@intel.com>,
David Cohen <david.a.cohen@linux.intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Damien Ramonda <damien.ramonda@intel.com>,
Jan Kara <jack@suse.cz>, David Rientjes <rientjes@google.com>,
Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm readahead: Fix sys_readahead breakage by reverting 2MB limit (bug 79111)
Date: Thu, 3 Jul 2014 11:29:38 -0700 [thread overview]
Message-ID: <CA+55aFwwSCrH5QDvrzzyHhRU5R849Mo8A3NdRMwm9OTeWH9diQ@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFyRgYW6Y8paYKGfqE205enhiPsZ1C8wrKpFavVXq7ZAtA@mail.gmail.com>
On Thu, Jul 3, 2014 at 11:22 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> So the bugzilla entry worries me a bit - we definitely do not want to
> regress in case somebody really relied on timing - but without more
> specific information I still think the real bug is just in the
> man-page.
Side note: the 2MB limit may be too small. 2M is peanuts on modern
machines, even for fairly slow IO, and there are lots of files (like
glibc etc) that people might want to read-ahead during boot. We
already do bigger read-ahead if people just do "read()" system calls.
So I could certainly imagine that we should increase it.
I do *not* think we should bow down to insane man-pages that have
always been wrong, though, and I don't think we should increase it to
"let's just read-ahead a whole ISO image" kind of sizes..
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-03 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 13:02 [PATCH] mm readahead: Fix sys_readahead breakage by reverting 2MB limit (bug 79111) Raghavendra K T
2014-07-03 15:41 ` Linus Torvalds
2014-07-03 18:11 ` Raghavendra K T
2014-07-03 18:22 ` Linus Torvalds
2014-07-03 18:29 ` Linus Torvalds [this message]
2014-07-03 18:38 ` Raghavendra K T
2014-07-03 18:50 ` Raghavendra K T
2014-07-03 18:53 ` Linus Torvalds
2014-07-03 18:56 ` Raghavendra K T
2014-07-03 19:05 ` Dave Jones
2014-07-03 19:43 ` John Stoffel
2014-07-03 21:58 ` Linus Torvalds
2014-10-03 20:57 ` Rafael Aquini
2014-07-03 18:35 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFwwSCrH5QDvrzzyHhRU5R849Mo8A3NdRMwm9OTeWH9diQ@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=damien.ramonda@intel.com \
--cc=david.a.cohen@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nacc@linux.vnet.ibm.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).